Skip to content

Commit 50b040e

Browse files
spasswolfBartosz Golaszewski
authored andcommitted
PCI/pwrctl: only call of_platform_populate() if CONFIG_OF is enabled
If of_platform_populate() is called when CONFIG_OF is not defined this leads to spurious error messages of the following type: pci 0000:00:01.1: failed to populate child OF nodes (-19) pci 0000:00:02.1: failed to populate child OF nodes (-19) Fixes: 8fb1861 ("PCI/pwrctl: Create platform devices for child OF nodes of the port node") Signed-off-by: Bert Karwatzki <spasswolf@web.de> Closes: https://lore.kernel.org/all/20240702173255.39932-1-superm1@kernel.org/ Reviewed-by: Lukas Wunner <lukas@wunner.de> Acked-by: Krzysztof Wilczyński <kw@linux.com> Reported-by: Praveenkumar Patil <PraveenKumar.Patil@amd.com> Acked-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> Link: https://lore.kernel.org/r/20240707183829.41519-1-spasswolf@web.de Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
1 parent eba6d0f commit 50b040e

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/pci/bus.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -356,7 +356,7 @@ void pci_bus_add_device(struct pci_dev *dev)
356356

357357
pci_dev_assign_added(dev, true);
358358

359-
if (pci_is_bridge(dev)) {
359+
if (IS_ENABLED(CONFIG_OF) && pci_is_bridge(dev)) {
360360
retval = of_platform_populate(dev->dev.of_node, NULL, NULL,
361361
&dev->dev);
362362
if (retval)

0 commit comments

Comments
 (0)