Skip to content

Commit 518c32a

Browse files
author
Trond Myklebust
committed
NFS: Initialise verifiers for visible dentries in nfs_atomic_open()
Ensure that the verifiers are initialised before calling d_splice_alias() in nfs_atomic_open(). Reported-by: Michael Stoler <michael.stoler@vastdata.com> Fixes: 809fd14 ("NFSv4: Ensure nfs_atomic_open set the dentry verifier on ENOENT") Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
1 parent 9bd5455 commit 518c32a

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

fs/nfs/dir.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2144,12 +2144,12 @@ int nfs_atomic_open(struct inode *dir, struct dentry *dentry,
21442144
d_drop(dentry);
21452145
switch (err) {
21462146
case -ENOENT:
2147-
d_splice_alias(NULL, dentry);
21482147
if (nfs_server_capable(dir, NFS_CAP_CASE_INSENSITIVE))
21492148
dir_verifier = inode_peek_iversion_raw(dir);
21502149
else
21512150
dir_verifier = nfs_save_change_attribute(dir);
21522151
nfs_set_verifier(dentry, dir_verifier);
2152+
d_splice_alias(NULL, dentry);
21532153
break;
21542154
case -EISDIR:
21552155
case -ENOTDIR:

0 commit comments

Comments
 (0)