bcachefs: Improve bch2_is_inode_open() warning message

Kent Overstreet · Kent Overstreet · commit 51b7cc7c0f96 · 2024-09-27T21:46:34.000-04:00
Signed-off-by: Kent Overstreet &lt;kent.overstreet@linux.dev&gt;
diff --git a/fs/bcachefs/fsck.c b/fs/bcachefs/fsck.c
@@ -963,7 +963,7 @@ static int check_inode_dirent_inode(struct btree_trans *trans, struct bkey_s_c i
 	return ret;
 }
 
-static bool bch2_inode_open(struct bch_fs *c, struct bpos p)
+static bool bch2_inode_is_open(struct bch_fs *c, struct bpos p)
 {
 	subvol_inum inum = {
 		.subvol = snapshot_t(c, p.snapshot)->subvol,
@@ -972,7 +972,7 @@ static bool bch2_inode_open(struct bch_fs *c, struct bpos p)
 
 	/* snapshot tree corruption, can't safely delete */
 	if (!inum.subvol) {
-		bch_err_ratelimited(c, "%s(): snapshot %u has no subvol", __func__, p.snapshot);
+		bch_warn_ratelimited(c, "%s(): snapshot %u has no subvol, unlinked but can't safely delete", __func__, p.snapshot);
 		return true;
 	}
 
@@ -1057,7 +1057,7 @@ static int check_inode(struct btree_trans *trans,
 	}
 
 	if (u.bi_flags & BCH_INODE_unlinked &&
-	    !bch2_inode_open(c, k.k->p) &&
+	    !bch2_inode_is_open(c, k.k->p) &&
 	    (!c->sb.clean ||
 	     fsck_err(trans, inode_unlinked_but_clean,
 		      "filesystem marked clean, but inode %llu unlinked",

Original file line number	Diff line number	Diff line change
`@@ -963,7 +963,7 @@ static int check_inode_dirent_inode(struct btree_trans *trans, struct bkey_s_c i`
`963`	`963`	`return ret;`
`964`	`964`	`}`
`965`	`965`
`966`		`-static bool bch2_inode_open(struct bch_fs *c, struct bpos p)`
	`966`	`+static bool bch2_inode_is_open(struct bch_fs *c, struct bpos p)`
`967`	`967`	`{`
`968`	`968`	`subvol_inum inum = {`
`969`	`969`	`.subvol = snapshot_t(c, p.snapshot)->subvol,`
`@@ -972,7 +972,7 @@ static bool bch2_inode_open(struct bch_fs *c, struct bpos p)`
`972`	`972`
`973`	`973`	`/* snapshot tree corruption, can't safely delete */`
`974`	`974`	`if (!inum.subvol) {`
`975`		`- bch_err_ratelimited(c, "%s(): snapshot %u has no subvol", __func__, p.snapshot);`
	`975`	`+ bch_warn_ratelimited(c, "%s(): snapshot %u has no subvol, unlinked but can't safely delete", __func__, p.snapshot);`
`976`	`976`	`return true;`
`977`	`977`	`}`
`978`	`978`
`@@ -1057,7 +1057,7 @@ static int check_inode(struct btree_trans *trans,`
`1057`	`1057`	`}`
`1058`	`1058`
`1059`	`1059`	`if (u.bi_flags & BCH_INODE_unlinked &&`
`1060`		`- !bch2_inode_open(c, k.k->p) &&`
	`1060`	`+ !bch2_inode_is_open(c, k.k->p) &&`
`1061`	`1061`	`(!c->sb.clean \|\|`
`1062`	`1062`	`fsck_err(trans, inode_unlinked_but_clean,`
`1063`	`1063`	`"filesystem marked clean, but inode %llu unlinked",`