Skip to content

Commit 5231002

Browse files
jhovoldsre
authored andcommitted
dt-bindings: power: reset: qcom-pon: fix inconsistent example
The current PON example is a bit of a mess after converting the binding document to yaml and in the process updating parts of the example to match the pmk8350 binding while leaving parts from the older pm8998 example in place. Clean up the example and make it consistent by adding some newline separators; dropping labels; removing stray spaces; fixing the PON node name; and fixing the unit address so that it matches the interrupt specifiers (which re-encodes the PON base address, 0x800 => 0x8). Fixes: 76ba190 ("dt-bindings: power: reset: qcom-pon: Convert qcom PON binding to yaml") Signed-off-by: Johan Hovold <johan+linaro@kernel.org> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Link: https://lore.kernel.org/r/20231130173017.12723-1-johan+linaro@kernel.org Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
1 parent 88f04bc commit 5231002

1 file changed

Lines changed: 8 additions & 5 deletions

File tree

Documentation/devicetree/bindings/power/reset/qcom,pon.yaml

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -111,21 +111,24 @@ examples:
111111
#include <dt-bindings/interrupt-controller/irq.h>
112112
#include <dt-bindings/input/linux-event-codes.h>
113113
#include <dt-bindings/spmi/spmi.h>
114-
spmi_bus: spmi@c440000 {
114+
115+
spmi@c440000 {
115116
reg = <0x0c440000 0x1100>;
116117
#address-cells = <2>;
117118
#size-cells = <0>;
118-
pmk8350: pmic@0 {
119+
120+
pmic@0 {
119121
reg = <0x0 SPMI_USID>;
120122
#address-cells = <1>;
121123
#size-cells = <0>;
122-
pmk8350_pon: pon_hlos@1300 {
123-
reg = <0x1300>;
124+
125+
pon@800 {
124126
compatible = "qcom,pm8998-pon";
127+
reg = <0x800>;
125128
126129
pwrkey {
127130
compatible = "qcom,pm8941-pwrkey";
128-
interrupts = < 0x0 0x8 0 IRQ_TYPE_EDGE_BOTH >;
131+
interrupts = <0x0 0x8 0 IRQ_TYPE_EDGE_BOTH>;
129132
debounce = <15625>;
130133
bias-pull-up;
131134
linux,code = <KEY_POWER>;

0 commit comments

Comments
 (0)