Skip to content

Commit 52721cf

Browse files
opsiffBartosz Golaszewski
authored andcommitted
gpio: regmap: Fix memleak in error path in gpio_regmap_register()
Call gpiochip_remove() to free the resources allocated by gpiochip_add_data() in error path. Fixes: 553b75d ("gpio: regmap: Allow to allocate regmap-irq device") Fixes: ae49581 ("gpio: regmap: add the .fixed_direction_output configuration parameter") CC: stable@vger.kernel.org Co-developed-by: WangYuli <wangyl5933@chinaunicom.cn> Signed-off-by: WangYuli <wangyl5933@chinaunicom.cn> Signed-off-by: Wentao Guan <guanwentao@uniontech.com> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Link: https://lore.kernel.org/r/20251204101303.30353-1-guanwentao@uniontech.com [Bartosz: reworked the commit message] Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
1 parent 7d80e24 commit 52721cf

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/gpio/gpio-regmap.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -338,7 +338,7 @@ struct gpio_regmap *gpio_regmap_register(const struct gpio_regmap_config *config
338338
config->regmap_irq_line, config->regmap_irq_flags,
339339
0, config->regmap_irq_chip, &gpio->irq_chip_data);
340340
if (ret)
341-
goto err_free_bitmap;
341+
goto err_remove_gpiochip;
342342

343343
irq_domain = regmap_irq_get_domain(gpio->irq_chip_data);
344344
} else

0 commit comments

Comments
 (0)