soc: apple: rtkit: Pass 0 as size for a NULL crashlog buffer

jannau · jannau · commit 52d08e419b25 · 2025-02-17T21:50:14.000+01:00
The crashlog size is not useful for the crashed() callback callee if the
passed buffer is NULL. To reduce the risk of NULL pointer derefences in
callees use size 0 in this case.

Signed-off-by: Janne Grunau &lt;j@jannau.net&gt;
diff --git a/drivers/soc/apple/rtkit.c b/drivers/soc/apple/rtkit.c
@@ -395,7 +395,7 @@ static void apple_rtkit_crashlog_rx(struct apple_rtkit *rtk, u64 msg)
 
 	rtk->crashed = true;
 	if (rtk->ops->crashed)
-		rtk->ops->crashed(rtk->cookie, bfr, rtk->crashlog_buffer.size);
+		rtk->ops->crashed(rtk->cookie, bfr, bfr ? rtk->crashlog_buffer.size : 0);
 }
 
 static void apple_rtkit_ioreport_rx(struct apple_rtkit *rtk, u64 msg)

Original file line number	Diff line number	Diff line change
`@@ -395,7 +395,7 @@ static void apple_rtkit_crashlog_rx(struct apple_rtkit *rtk, u64 msg)`
`395`	`395`
`396`	`396`	`rtk->crashed = true;`
`397`	`397`	`if (rtk->ops->crashed)`
`398`		`- rtk->ops->crashed(rtk->cookie, bfr, rtk->crashlog_buffer.size);`
	`398`	`+ rtk->ops->crashed(rtk->cookie, bfr, bfr ? rtk->crashlog_buffer.size : 0);`
`399`	`399`	`}`
`400`	`400`
`401`	`401`	`static void apple_rtkit_ioreport_rx(struct apple_rtkit *rtk, u64 msg)`