Skip to content

Commit 52fa3b6

Browse files
minakuba-moo
authored andcommitted
memory-provider: fix compilation issue without SYSFS
When CONFIG_SYSFS is not set, the kernel fails to compile: net/core/page_pool_user.c:368:45: error: implicit declaration of function 'get_netdev_rx_queue_index' [-Werror=implicit-function-declaration] 368 | if (pool->slow.queue_idx == get_netdev_rx_queue_index(rxq)) { | ^~~~~~~~~~~~~~~~~~~~~~~~~ When CONFIG_SYSFS is not set, get_netdev_rx_queue_index() is not defined as well. Fix by removing the ifdef around get_netdev_rx_queue_index(). It is not needed anymore after commit e817f85 ("xdp: generic XDP handling of xdp_rxq_info") removed most of the CONFIG_SYSFS ifdefs. Fixes: 0f92140 ("memory-provider: dmabuf devmem memory provider") Cc: Matthieu Baerts (NGI0) <matttbe@kernel.org> Signed-off-by: Mina Almasry <almasrymina@google.com> Link: https://patch.msgid.link/20240913032824.2117095-1-almasrymina@google.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent b523f23 commit 52fa3b6

1 file changed

Lines changed: 0 additions & 2 deletions

File tree

include/net/netdev_rx_queue.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,6 @@ __netif_get_rx_queue(struct net_device *dev, unsigned int rxq)
4545
return dev->_rx + rxq;
4646
}
4747

48-
#ifdef CONFIG_SYSFS
4948
static inline unsigned int
5049
get_netdev_rx_queue_index(struct netdev_rx_queue *queue)
5150
{
@@ -55,7 +54,6 @@ get_netdev_rx_queue_index(struct netdev_rx_queue *queue)
5554
BUG_ON(index >= dev->num_rx_queues);
5655
return index;
5756
}
58-
#endif
5957

6058
int netdev_rx_queue_restart(struct net_device *dev, unsigned int rxq);
6159

0 commit comments

Comments
 (0)