net/mlx5: HWS: Fix memory leak in mlx5hws_definer_calc_layout

Cosmin Ratiu · kuba-moo · commit 530b69a26952 · 2024-12-04T19:43:45.000-08:00
It allocates a match template, which creates a compressed definer fc struct, but that is not deallocated. This commit fixes that. Fixes: 74a778b ("net/mlx5: HWS, added definers handling") Signed-off-by: Cosmin Ratiu <cratiu@nvidia.com> Reviewed-by: Yevgeny Kliteynik <kliteyn@nvidia.com> Signed-off-by: Tariq Toukan <tariqt@nvidia.com> Link: https://patch.msgid.link/20241203204920.232744-2-tariqt@nvidia.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/bwc_complex.c b/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/bwc_complex.c
@@ -39,6 +39,8 @@ bool mlx5hws_bwc_match_params_is_complex(struct mlx5hws_context *ctx,
 		} else {
 			mlx5hws_err(ctx, "Failed to calculate matcher definer layout\n");
 		}
+	} else {
+		kfree(mt->fc);
 	}
 
 	mlx5hws_match_template_destroy(mt);

Original file line number	Diff line number	Diff line change
`@@ -39,6 +39,8 @@ bool mlx5hws_bwc_match_params_is_complex(struct mlx5hws_context *ctx,`
`39`	`39`	`} else {`
`40`	`40`	`mlx5hws_err(ctx, "Failed to calculate matcher definer layout\n");`
`41`	`41`	`}`
	`42`	`+ } else {`
	`43`	`+ kfree(mt->fc);`
`42`	`44`	`}`
`43`	`45`
`44`	`46`	`mlx5hws_match_template_destroy(mt);`