Skip to content

Commit 53a8384

Browse files
committed
powerpc: asm/io.h: remove split ioread64/iowrite64 helpers
In previous kernels, there were conflicting definitions for what ioread64_lo_hi() and similar functions were supposed to do on architectures with native 64-bit MMIO. Based on the actual usage in drivers, they are in fact expected to be a pair of 32-bit accesses on all architectures, which makes the powerpc64 definition wrong. Remove it and use the generic implementation instead. Drivers that want to have split lo/hi or hi/lo accesses on 32-bit architectures but can use 64-bit accesses where supported should instead use ioread64()/iowrite64() after including the corresponding header file. Signed-off-by: Arnd Bergmann <arnd@arndb.de>
1 parent 4d182c5 commit 53a8384

1 file changed

Lines changed: 0 additions & 48 deletions

File tree

  • arch/powerpc/include/asm

arch/powerpc/include/asm/io.h

Lines changed: 0 additions & 48 deletions
Original file line numberDiff line numberDiff line change
@@ -738,35 +738,11 @@ static inline unsigned int ioread32be(const void __iomem *addr)
738738
#define ioread32be ioread32be
739739

740740
#ifdef __powerpc64__
741-
static inline u64 ioread64_lo_hi(const void __iomem *addr)
742-
{
743-
return readq(addr);
744-
}
745-
#define ioread64_lo_hi ioread64_lo_hi
746-
747-
static inline u64 ioread64_hi_lo(const void __iomem *addr)
748-
{
749-
return readq(addr);
750-
}
751-
#define ioread64_hi_lo ioread64_hi_lo
752-
753741
static inline u64 ioread64be(const void __iomem *addr)
754742
{
755743
return readq_be(addr);
756744
}
757745
#define ioread64be ioread64be
758-
759-
static inline u64 ioread64be_lo_hi(const void __iomem *addr)
760-
{
761-
return readq_be(addr);
762-
}
763-
#define ioread64be_lo_hi ioread64be_lo_hi
764-
765-
static inline u64 ioread64be_hi_lo(const void __iomem *addr)
766-
{
767-
return readq_be(addr);
768-
}
769-
#define ioread64be_hi_lo ioread64be_hi_lo
770746
#endif /* __powerpc64__ */
771747

772748
static inline void iowrite16be(u16 val, void __iomem *addr)
@@ -782,35 +758,11 @@ static inline void iowrite32be(u32 val, void __iomem *addr)
782758
#define iowrite32be iowrite32be
783759

784760
#ifdef __powerpc64__
785-
static inline void iowrite64_lo_hi(u64 val, void __iomem *addr)
786-
{
787-
writeq(val, addr);
788-
}
789-
#define iowrite64_lo_hi iowrite64_lo_hi
790-
791-
static inline void iowrite64_hi_lo(u64 val, void __iomem *addr)
792-
{
793-
writeq(val, addr);
794-
}
795-
#define iowrite64_hi_lo iowrite64_hi_lo
796-
797761
static inline void iowrite64be(u64 val, void __iomem *addr)
798762
{
799763
writeq_be(val, addr);
800764
}
801765
#define iowrite64be iowrite64be
802-
803-
static inline void iowrite64be_lo_hi(u64 val, void __iomem *addr)
804-
{
805-
writeq_be(val, addr);
806-
}
807-
#define iowrite64be_lo_hi iowrite64be_lo_hi
808-
809-
static inline void iowrite64be_hi_lo(u64 val, void __iomem *addr)
810-
{
811-
writeq_be(val, addr);
812-
}
813-
#define iowrite64be_hi_lo iowrite64be_hi_lo
814766
#endif /* __powerpc64__ */
815767

816768
struct pci_dev;

0 commit comments

Comments
 (0)