Skip to content

Commit 53ad4a9

Browse files
CeS-3Bartosz Golaszewski
authored andcommitted
gpio: virtuser: fix UAF in configfs release path
The gpio-virtuser configfs release path uses guard(mutex) to protect the device structure. However, the device is freed before the guard cleanup runs, causing mutex_unlock() to operate on freed memory. Specifically, gpio_virtuser_device_config_group_release() destroys the mutex and frees the device while still inside the guard(mutex) scope. When the function returns, the guard cleanup invokes mutex_unlock(&dev->lock), resulting in a slab use-after-free. Limit the mutex lifetime by using a scoped_guard() only around the activation check, so that the lock is released before mutex_destroy() and kfree() are called. Fixes: 91581c4 ("gpio: virtuser: new virtual testing driver for the GPIO API") Signed-off-by: Yuhao Huang <nekowong743@gmail.com> Link: https://lore.kernel.org/r/20260126040348.11167-1-yuhaohuang@YuhaodeMacBook-Pro.local Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
1 parent c0ae43d commit 53ad4a9

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

drivers/gpio/gpio-virtuser.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1682,10 +1682,10 @@ static void gpio_virtuser_device_config_group_release(struct config_item *item)
16821682
{
16831683
struct gpio_virtuser_device *dev = to_gpio_virtuser_device(item);
16841684

1685-
guard(mutex)(&dev->lock);
1686-
1687-
if (gpio_virtuser_device_is_live(dev))
1688-
gpio_virtuser_device_deactivate(dev);
1685+
scoped_guard(mutex, &dev->lock) {
1686+
if (gpio_virtuser_device_is_live(dev))
1687+
gpio_virtuser_device_deactivate(dev);
1688+
}
16891689

16901690
mutex_destroy(&dev->lock);
16911691
ida_free(&gpio_virtuser_ida, dev->id);

0 commit comments

Comments
 (0)