Skip to content

Commit 53c4105

Browse files
committed
eventfs: Have the inodes all for files and directories all be the same
The dentries and inodes are created in the readdir for the sole purpose of getting a consistent inode number. Linus stated that is unnecessary, and that all inodes can have the same inode number. For a virtual file system they are pretty meaningless. Instead use a single unique inode number for all files and one for all directories. Link: https://lore.kernel.org/all/20240116133753.2808d45e@gandalf.local.home/ Link: https://lore.kernel.org/linux-trace-kernel/20240116211353.412180363@goodmis.org Cc: Masami Hiramatsu <mhiramat@kernel.org> Cc: Mark Rutland <mark.rutland@arm.com> Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com> Cc: Christian Brauner <brauner@kernel.org> Cc: Al Viro <viro@ZenIV.linux.org.uk> Cc: Ajay Kaher <ajay.kaher@broadcom.com> Suggested-by: Linus Torvalds <torvalds@linux-foundation.org> Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
1 parent 1de94b5 commit 53c4105

1 file changed

Lines changed: 10 additions & 0 deletions

File tree

fs/tracefs/event_inode.c

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,10 @@
3232
*/
3333
static DEFINE_MUTEX(eventfs_mutex);
3434

35+
/* Choose something "unique" ;-) */
36+
#define EVENTFS_FILE_INODE_INO 0x12c4e37
37+
#define EVENTFS_DIR_INODE_INO 0x134b2f5
38+
3539
/*
3640
* The eventfs_inode (ei) itself is protected by SRCU. It is released from
3741
* its parent's list and will have is_freed set (under eventfs_mutex).
@@ -352,6 +356,9 @@ static struct dentry *create_file(const char *name, umode_t mode,
352356
inode->i_fop = fop;
353357
inode->i_private = data;
354358

359+
/* All files will have the same inode number */
360+
inode->i_ino = EVENTFS_FILE_INODE_INO;
361+
355362
ti = get_tracefs(inode);
356363
ti->flags |= TRACEFS_EVENT_INODE;
357364
d_instantiate(dentry, inode);
@@ -388,6 +395,9 @@ static struct dentry *create_dir(struct eventfs_inode *ei, struct dentry *parent
388395
inode->i_op = &eventfs_root_dir_inode_operations;
389396
inode->i_fop = &eventfs_file_operations;
390397

398+
/* All directories will have the same inode number */
399+
inode->i_ino = EVENTFS_DIR_INODE_INO;
400+
391401
ti = get_tracefs(inode);
392402
ti->flags |= TRACEFS_EVENT_INODE;
393403

0 commit comments

Comments
 (0)