fscrypt: Drop FORBID_WEAK_KEYS flag for AES-ECB

Eric Biggers · Eric Biggers · commit 53d9218d8d38 · 2025-07-10T12:33:08.000-07:00
This flag only has an effect for DES, 3DES, and XTS mode. It does nothing for AES-ECB, as there is no concept of weak keys for AES. Link: https://lore.kernel.org/r/20250710060754.637098-3-ebiggers@kernel.org Signed-off-by: Eric Biggers <ebiggers@kernel.org>
diff --git a/fs/crypto/keysetup_v1.c b/fs/crypto/keysetup_v1.c
@@ -59,7 +59,6 @@ static int derive_key_aes(const u8 *master_key,
 		tfm = NULL;
 		goto out;
 	}
-	crypto_skcipher_set_flags(tfm, CRYPTO_TFM_REQ_FORBID_WEAK_KEYS);
 	req = skcipher_request_alloc(tfm, GFP_KERNEL);
 	if (!req) {
 		res = -ENOMEM;

Original file line number	Diff line number	Diff line change
`@@ -59,7 +59,6 @@ static int derive_key_aes(const u8 *master_key,`
`59`	`59`	`tfm = NULL;`
`60`	`60`	`goto out;`
`61`	`61`	`}`
`62`		`- crypto_skcipher_set_flags(tfm, CRYPTO_TFM_REQ_FORBID_WEAK_KEYS);`
`63`	`62`	`req = skcipher_request_alloc(tfm, GFP_KERNEL);`
`64`	`63`	`if (!req) {`
`65`	`64`	`res = -ENOMEM;`