Skip to content

Commit 53f5094

Browse files
kyletsoadlgregkh
authored andcommitted
usb: typec: Return size of buffer if pd_set operation succeeds
The attribute writing should return the number of bytes used from the buffer on success. Fixes: a7cff92 ("usb: typec: USB Power Delivery helpers for ports and partners") Cc: stable@vger.kernel.org Signed-off-by: Kyle Tso <kyletso@google.com> Reviewed-by: Guenter Roeck <linux@roeck-us.net> Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com> Link: https://lore.kernel.org/r/20240319074309.3306579-1-kyletso@google.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 2a587a0 commit 53f5094

1 file changed

Lines changed: 6 additions & 1 deletion

File tree

drivers/usb/typec/class.c

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1310,6 +1310,7 @@ static ssize_t select_usb_power_delivery_store(struct device *dev,
13101310
{
13111311
struct typec_port *port = to_typec_port(dev);
13121312
struct usb_power_delivery *pd;
1313+
int ret;
13131314

13141315
if (!port->ops || !port->ops->pd_set)
13151316
return -EOPNOTSUPP;
@@ -1318,7 +1319,11 @@ static ssize_t select_usb_power_delivery_store(struct device *dev,
13181319
if (!pd)
13191320
return -EINVAL;
13201321

1321-
return port->ops->pd_set(port, pd);
1322+
ret = port->ops->pd_set(port, pd);
1323+
if (ret)
1324+
return ret;
1325+
1326+
return size;
13221327
}
13231328

13241329
static ssize_t select_usb_power_delivery_show(struct device *dev,

0 commit comments

Comments
 (0)