Skip to content

Commit 54a2add

Browse files
krzkandersson
authored andcommitted
soc: qcom: Use str_enable_disable-like helpers
Replace ternary (condition ? "enable" : "disable") syntax with helpers from string_choices.h because: 1. Simple function call with one argument is easier to read. Ternary operator has three arguments and with wrapping might lead to quite long code. 2. Is slightly shorter thus also easier to read. 3. It brings uniformity in the text - same string. 4. Allows deduping by the linker, which results in a smaller binary file. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Link: https://lore.kernel.org/r/20250114203646.1013708-1-krzysztof.kozlowski@linaro.org Signed-off-by: Bjorn Andersson <andersson@kernel.org>
1 parent 2014c95 commit 54a2add

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

drivers/soc/qcom/qcom_aoss.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
#include <linux/platform_device.h>
1313
#include <linux/thermal.h>
1414
#include <linux/slab.h>
15+
#include <linux/string_choices.h>
1516
#include <linux/soc/qcom/qcom_aoss.h>
1617

1718
#define CREATE_TRACE_POINTS
@@ -358,7 +359,7 @@ static int qmp_cdev_set_cur_state(struct thermal_cooling_device *cdev,
358359
return 0;
359360

360361
ret = qmp_send(qmp_cdev->qmp, "{class: volt_flr, event:zero_temp, res:%s, value:%s}",
361-
qmp_cdev->name, cdev_state ? "on" : "off");
362+
qmp_cdev->name, str_on_off(cdev_state));
362363
if (!ret)
363364
qmp_cdev->state = cdev_state;
364365

0 commit comments

Comments
 (0)