PCI/P2PDMA: Reduce scope of pci_has_p2pmem()

rleon · bjorn-helgaas · commit 54dbd2a8e974 · 2025-09-03T17:01:39.000-05:00
pci_has_p2pmem() is not used outside of p2pdma.c, and there is no need to export it for use by modules. Signed-off-by: Leon Romanovsky <leonro@nvidia.com> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> Reviewed-by: Logan Gunthorpe <logang@deltatee.com> Link: https://patch.msgid.link/d40f3f1decf54c9236bc38b48a6aae612a5c182f.1756900291.git.leon@kernel.org
diff --git a/drivers/pci/p2pdma.c b/drivers/pci/p2pdma.c
@@ -738,7 +738,7 @@ EXPORT_SYMBOL_GPL(pci_p2pdma_distance_many);
  * pci_has_p2pmem - check if a given PCI device has published any p2pmem
  * @pdev: PCI device to check
  */
-bool pci_has_p2pmem(struct pci_dev *pdev)
+static bool pci_has_p2pmem(struct pci_dev *pdev)
 {
 	struct pci_p2pdma *p2pdma;
 	bool res;
@@ -750,7 +750,6 @@ bool pci_has_p2pmem(struct pci_dev *pdev)
 
 	return res;
 }
-EXPORT_SYMBOL_GPL(pci_has_p2pmem);
 
 /**
  * pci_p2pmem_find_many - find a peer-to-peer DMA memory device compatible with
diff --git a/include/linux/pci-p2pdma.h b/include/linux/pci-p2pdma.h
@@ -21,7 +21,6 @@ int pci_p2pdma_add_resource(struct pci_dev *pdev, int bar, size_t size,
 		u64 offset);
 int pci_p2pdma_distance_many(struct pci_dev *provider, struct device **clients,
 			     int num_clients, bool verbose);
-bool pci_has_p2pmem(struct pci_dev *pdev);
 struct pci_dev *pci_p2pmem_find_many(struct device **clients, int num_clients);
 void *pci_alloc_p2pmem(struct pci_dev *pdev, size_t size);
 void pci_free_p2pmem(struct pci_dev *pdev, void *addr, size_t size);
@@ -45,10 +44,6 @@ static inline int pci_p2pdma_distance_many(struct pci_dev *provider,
 {
 	return -1;
 }
-static inline bool pci_has_p2pmem(struct pci_dev *pdev)
-{
-	return false;
-}
 static inline struct pci_dev *pci_p2pmem_find_many(struct device **clients,
 						   int num_clients)
 {

Original file line number	Diff line number	Diff line change
`@@ -738,7 +738,7 @@ EXPORT_SYMBOL_GPL(pci_p2pdma_distance_many);`
`738`	`738`	`* pci_has_p2pmem - check if a given PCI device has published any p2pmem`
`739`	`739`	`* @pdev: PCI device to check`
`740`	`740`	`*/`
`741`		`-bool pci_has_p2pmem(struct pci_dev *pdev)`
	`741`	`+static bool pci_has_p2pmem(struct pci_dev *pdev)`
`742`	`742`	`{`
`743`	`743`	`struct pci_p2pdma *p2pdma;`
`744`	`744`	`bool res;`
`@@ -750,7 +750,6 @@ bool pci_has_p2pmem(struct pci_dev *pdev)`
`750`	`750`
`751`	`751`	`return res;`
`752`	`752`	`}`
`753`		`-EXPORT_SYMBOL_GPL(pci_has_p2pmem);`
`754`	`753`
`755`	`754`	`/**`
`756`	`755`	`* pci_p2pmem_find_many - find a peer-to-peer DMA memory device compatible with`
Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,6 @@ int pci_p2pdma_add_resource(struct pci_dev *pdev, int bar, size_t size,`
`21`	`21`	`u64 offset);`
`22`	`22`	`int pci_p2pdma_distance_many(struct pci_dev provider, struct device *clients,`
`23`	`23`	`int num_clients, bool verbose);`
`24`		`-bool pci_has_p2pmem(struct pci_dev *pdev);`
`25`	`24`	`struct pci_dev pci_p2pmem_find_many(struct device *clients, int num_clients);`
`26`	`25`	`void pci_alloc_p2pmem(struct pci_dev pdev, size_t size);`
`27`	`26`	`void pci_free_p2pmem(struct pci_dev pdev, void addr, size_t size);`
`@@ -45,10 +44,6 @@ static inline int pci_p2pdma_distance_many(struct pci_dev *provider,`
`45`	`44`	`{`
`46`	`45`	`return -1;`
`47`	`46`	`}`
`48`		`-static inline bool pci_has_p2pmem(struct pci_dev *pdev)`
`49`		`-{`
`50`		`- return false;`
`51`		`-}`
`52`	`47`	`static inline struct pci_dev pci_p2pmem_find_many(struct device *clients,`
`53`	`48`	`int num_clients)`
`54`	`49`	`{`