Skip to content

Commit 554736b

Browse files
Haoxiang Ligregkh
authored andcommitted
smb: client: Add check for next_buffer in receive_encrypted_standard()
commit 860ca5e upstream. Add check for the return value of cifs_buf_get() and cifs_small_buf_get() in receive_encrypted_standard() to prevent null pointer dereference. Fixes: eec04ea ("smb: client: fix OOB in receive_encrypted_standard()") Cc: stable@vger.kernel.org Signed-off-by: Haoxiang Li <haoxiang_li2024@163.com> Signed-off-by: Steve French <stfrench@microsoft.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 37dda79 commit 554736b

1 file changed

Lines changed: 4 additions & 0 deletions

File tree

fs/smb/client/smb2ops.c

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4964,6 +4964,10 @@ receive_encrypted_standard(struct TCP_Server_Info *server,
49644964
next_buffer = (char *)cifs_buf_get();
49654965
else
49664966
next_buffer = (char *)cifs_small_buf_get();
4967+
if (!next_buffer) {
4968+
cifs_server_dbg(VFS, "No memory for (large) SMB response\n");
4969+
return -1;
4970+
}
49674971
memcpy(next_buffer, buf + next_cmd, pdu_length - next_cmd);
49684972
}
49694973

0 commit comments

Comments
 (0)