Skip to content

Commit 572239f

Browse files
mbrost05rodrigovivi
authored andcommitted
drm/xe: Remove fence check from send_tlb_invalidation
'fence' argument in send_tlb_invalidation cannot be NULL, remove non-NULL check from send_tlb_invalidation. Reported-by: kernel test robot <lkp@intel.com> Reported-by: Dan Carpenter <dan.carpenter@linaro.org> Closes: https://lore.kernel.org/r/202407231049.esig0Fkb-lkp@intel.com/ Fixes: 58bfe66 ("drm/xe: Drop xe_gt_tlb_invalidation_wait") Signed-off-by: Matthew Brost <matthew.brost@intel.com> Reviewed-by: Nirmoy Das <nirmoy.das@intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20240723190714.1744653-1-matthew.brost@intel.com Signed-off-by: Nirmoy Das <nirmoy.das@intel.com> (cherry picked from commit 6482253) Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
1 parent a265535 commit 572239f

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

drivers/gpu/drm/xe/xe_gt_tlb_invalidation.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -182,7 +182,7 @@ static int send_tlb_invalidation(struct xe_guc *guc,
182182
action[1] = seqno;
183183
ret = xe_guc_ct_send_locked(&guc->ct, action, len,
184184
G2H_LEN_DW_TLB_INVALIDATE, 1);
185-
if (!ret && fence) {
185+
if (!ret) {
186186
spin_lock_irq(&gt->tlb_invalidation.pending_lock);
187187
/*
188188
* We haven't actually published the TLB fence as per
@@ -203,7 +203,7 @@ static int send_tlb_invalidation(struct xe_guc *guc,
203203
tlb_timeout_jiffies(gt));
204204
}
205205
spin_unlock_irq(&gt->tlb_invalidation.pending_lock);
206-
} else if (ret < 0 && fence) {
206+
} else if (ret < 0) {
207207
__invalidation_fence_signal(xe, fence);
208208
}
209209
if (!ret) {

0 commit comments

Comments
 (0)