Skip to content

Commit 58efaf6

Browse files
hoshinolinajannau
authored andcommitted
iommu: apple-dart: Power on device when handling IRQs
It's possible for an IRQ to fire and the device to be RPM suspended before we can handle it, which then causes device register accesses to fail in the IRQ handler. Since RPM is IRQ-safe for this device, just make sure we power on the DART in the IRQ handler too. Signed-off-by: Asahi Lina <lina@asahilina.net>
1 parent 271f8ea commit 58efaf6

1 file changed

Lines changed: 12 additions & 1 deletion

File tree

drivers/iommu/apple-dart.c

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1102,6 +1102,17 @@ static irqreturn_t apple_dart_t8110_irq(int irq, void *dev)
11021102
return IRQ_HANDLED;
11031103
}
11041104

1105+
static irqreturn_t apple_dart_irq(int irq, void *dev)
1106+
{
1107+
irqreturn_t ret;
1108+
struct apple_dart *dart = dev;
1109+
1110+
WARN_ON(pm_runtime_get_sync(dart->dev) < 0);
1111+
ret = dart->hw->irq_handler(irq, dev);
1112+
pm_runtime_put(dart->dev);
1113+
return ret;
1114+
}
1115+
11051116
static int apple_dart_probe(struct platform_device *pdev)
11061117
{
11071118
int ret;
@@ -1174,7 +1185,7 @@ static int apple_dart_probe(struct platform_device *pdev)
11741185
if (ret)
11751186
goto err_clk_disable;
11761187

1177-
ret = request_irq(dart->irq, dart->hw->irq_handler, IRQF_SHARED,
1188+
ret = request_irq(dart->irq, apple_dart_irq, IRQF_SHARED,
11781189
"apple-dart fault handler", dart);
11791190
if (ret)
11801191
goto err_clk_disable;

0 commit comments

Comments
 (0)