Skip to content

Commit 597b362

Browse files
Bartosz GolaszewskiLinus Walleij
authored andcommitted
pinctrl: spacemit: destroy mutex at driver detach
The mutex initialized in probe() is never cleaned up. Use devm_mutex_init() to destroy it automatically. Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> Reviewed-by: Javier Martinez Canillas <javierm@redhat.com> Reviewed-by: Yixun Lan <dlan@gentoo.org> Link: https://lore.kernel.org/20250305102710.52762-1-brgl@bgdev.pl Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
1 parent 8171e7b commit 597b362

1 file changed

Lines changed: 5 additions & 1 deletion

File tree

drivers/pinctrl/spacemit/pinctrl-k1.c

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
#include <linux/seq_file.h>
1010
#include <linux/spinlock.h>
1111
#include <linux/module.h>
12+
#include <linux/mutex.h>
1213

1314
#include <linux/pinctrl/pinconf-generic.h>
1415
#include <linux/pinctrl/pinconf.h>
@@ -749,7 +750,10 @@ static int spacemit_pinctrl_probe(struct platform_device *pdev)
749750
pctrl->data = pctrl_data;
750751
pctrl->dev = dev;
751752
raw_spin_lock_init(&pctrl->lock);
752-
mutex_init(&pctrl->mutex);
753+
754+
ret = devm_mutex_init(dev, &pctrl->mutex);
755+
if (ret)
756+
return ret;
753757

754758
platform_set_drvdata(pdev, pctrl);
755759

0 commit comments

Comments
 (0)