Skip to content

Commit 59b0afd

Browse files
Yuuoniyherbertx
authored andcommitted
crypto: hisilicon/qm - Fix device reference leak in qm_get_qos_value
The qm_get_qos_value() function calls bus_find_device_by_name() which increases the device reference count, but fails to call put_device() to balance the reference count and lead to a device reference leak. Add put_device() calls in both the error path and success path to properly balance the reference count. Found via static analysis. Fixes: 22d7a6c ("crypto: hisilicon/qm - add pci bdf number check") Cc: stable@vger.kernel.org Signed-off-by: Miaoqian Lin <linmq006@gmail.com> Reviewed-by: Longfang Liu <liulongfang@huawei.com> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
1 parent 3c9bf72 commit 59b0afd

1 file changed

Lines changed: 2 additions & 0 deletions

File tree

  • drivers/crypto/hisilicon

drivers/crypto/hisilicon/qm.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3871,10 +3871,12 @@ static ssize_t qm_get_qos_value(struct hisi_qm *qm, const char *buf,
38713871
pdev = container_of(dev, struct pci_dev, dev);
38723872
if (pci_physfn(pdev) != qm->pdev) {
38733873
pci_err(qm->pdev, "the pdev input does not match the pf!\n");
3874+
put_device(dev);
38743875
return -EINVAL;
38753876
}
38763877

38773878
*fun_index = pdev->devfn;
3879+
put_device(dev);
38783880

38793881
return 0;
38803882
}

0 commit comments

Comments
 (0)