Skip to content

Commit 59f3222

Browse files
committed
rust: of: Discourage us of "of" properties
Use FwNode based device properties instead. Signed-off-by: Janne Grunau <j@jannau.net>
1 parent 9a0f08f commit 59f3222

1 file changed

Lines changed: 8 additions & 8 deletions

File tree

rust/kernel/of.rs

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -107,24 +107,24 @@ impl Node {
107107
}
108108

109109
/// Returns the name of the node.
110-
pub fn name(&self) -> &CStr {
110+
pub(crate) fn name(&self) -> &CStr {
111111
// SAFETY: The lifetime of the `CStr` is the same as the lifetime of this `Node`.
112112
unsafe { CStr::from_char_ptr(self.node().name) }
113113
}
114114

115115
/// Returns the phandle for this node.
116-
pub fn phandle(&self) -> PHandle {
116+
pub(crate) fn phandle(&self) -> PHandle {
117117
self.node().phandle
118118
}
119119

120120
/// Returns the full name (with address) for this node.
121-
pub fn full_name(&self) -> &CStr {
121+
pub(crate) fn full_name(&self) -> &CStr {
122122
// SAFETY: The lifetime of the `CStr` is the same as the lifetime of this `Node`.
123123
unsafe { CStr::from_char_ptr(self.node().full_name) }
124124
}
125125

126126
/// Returns `true` if the node is the root node.
127-
pub fn is_root(&self) -> bool {
127+
pub(crate) fn is_root(&self) -> bool {
128128
#[cfg(not(CONFIG_OF))]
129129
{
130130
false
@@ -137,7 +137,7 @@ impl Node {
137137
}
138138

139139
/// Returns the parent node, if any.
140-
pub fn parent(&self) -> Option<Node> {
140+
pub(crate) fn parent(&self) -> Option<Node> {
141141
#[cfg(not(CONFIG_OF))]
142142
{
143143
None
@@ -168,7 +168,7 @@ impl Node {
168168

169169
/// Find a child by its name and return it, or None if not found.
170170
#[allow(unused_variables)]
171-
pub fn get_child_by_name(&self, name: &CStr) -> Option<Node> {
171+
pub(crate) fn get_child_by_name(&self, name: &CStr) -> Option<Node> {
172172
#[cfg(not(CONFIG_OF))]
173173
{
174174
None
@@ -188,7 +188,7 @@ impl Node {
188188
/// Returns `None` if there is no match, or `Some<NonZeroU32>` if there is, with the value
189189
/// representing as match score (higher values for more specific compatible matches).
190190
#[allow(unused_variables)]
191-
pub fn is_compatible(&self, compatible: &CStr) -> Option<NonZeroU32> {
191+
pub(crate) fn is_compatible(&self, compatible: &CStr) -> Option<NonZeroU32> {
192192
#[cfg(not(CONFIG_OF))]
193193
let ret = 0;
194194
#[cfg(CONFIG_OF)]
@@ -246,7 +246,7 @@ impl Node {
246246

247247
#[allow(unused_variables)]
248248
/// Look up a node property by name, returning a `Property` object if found.
249-
pub fn find_property(&self, propname: &CStr) -> Option<Property<'_>> {
249+
pub(crate) fn find_property(&self, propname: &CStr) -> Option<Property<'_>> {
250250
#[cfg(not(CONFIG_OF))]
251251
{
252252
None

0 commit comments

Comments
 (0)