nfsd: ignore ATTR_DELEG when checking ia_valid before notify_change()

jtlayton · chucklever · commit 5affb498e70b · 2025-09-21T19:24:50.000-04:00
If the only flag left is ATTR_DELEG, then there are no changes to be made. Fixes: 7e13f4f ("nfsd: handle delegated timestamps in SETATTR") Signed-off-by: Jeff Layton <jlayton@kernel.org> Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
diff --git a/fs/nfsd/vfs.c b/fs/nfsd/vfs.c
@@ -467,7 +467,7 @@ static int __nfsd_setattr(struct dentry *dentry, struct iattr *iap)
 			return 0;
 	}
 
-	if (!iap->ia_valid)
+	if ((iap->ia_valid & ~ATTR_DELEG) == 0)
 		return 0;
 
 	/*

Original file line number	Diff line number	Diff line change
`@@ -467,7 +467,7 @@ static int __nfsd_setattr(struct dentry dentry, struct iattr iap)`
`467`	`467`	`return 0;`
`468`	`468`	`}`
`469`	`469`
`470`		`- if (!iap->ia_valid)`
	`470`	`+ if ((iap->ia_valid & ~ATTR_DELEG) == 0)`
`471`	`471`	`return 0;`
`472`	`472`
`473`	`473`	`/*`