Skip to content

Commit 5c4e15e

Browse files
Muhammad Usama Anjumbroonie
authored andcommitted
ASoC: mediatek: mt8365: check validity before usage of i2s_data
There may be a case where i2s_data may not get initialized by the for loop which will cause the kernel crash. Initialize the i2s_data to NULL and abort execute if it isn't found. Fixes: 402bbb1 ("ASoC: mediatek: mt8365: Add I2S DAI support") Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> Link: https://patch.msgid.link/20240911111317.4072349-1-usama.anjum@collabora.com Signed-off-by: Mark Brown <broonie@kernel.org>
1 parent 0b0aa67 commit 5c4e15e

1 file changed

Lines changed: 4 additions & 1 deletion

File tree

sound/soc/mediatek/mt8365/mt8365-dai-i2s.c

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -465,13 +465,16 @@ void mt8365_afe_set_i2s_out_enable(struct mtk_base_afe *afe, bool enable)
465465
int i;
466466
unsigned long flags;
467467
struct mt8365_afe_private *afe_priv = afe->platform_priv;
468-
struct mtk_afe_i2s_priv *i2s_data;
468+
struct mtk_afe_i2s_priv *i2s_data = NULL;
469469

470470
for (i = 0; i < DAI_I2S_NUM; i++) {
471471
if (mt8365_i2s_priv[i].adda_link)
472472
i2s_data = afe_priv->dai_priv[mt8365_i2s_priv[i].id];
473473
}
474474

475+
if (!i2s_data)
476+
return;
477+
475478
spin_lock_irqsave(&afe_priv->afe_ctrl_lock, flags);
476479

477480
if (enable) {

0 commit comments

Comments
 (0)