slimbus: messaging: Remove redundant code

Qiang Liu · gregkh · commit 5c6794f16b22 · 2025-09-12T15:47:37.000+02:00
Assigning txn->comp to itself has no effect. Signed-off-by: Qiang Liu <liuqiang@kylinos.cn> Signed-off-by: Srinivas Kandagatla <srini@kernel.org> Link: https://lore.kernel.org/r/20250912131202.303026-3-srini@kernel.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
diff --git a/drivers/slimbus/messaging.c b/drivers/slimbus/messaging.c
@@ -143,8 +143,6 @@ int slim_do_transfer(struct slim_controller *ctrl, struct slim_msg_txn *txn)
 
 		if (!txn->msg->comp)
 			txn->comp = &done;
-		else
-			txn->comp = txn->comp;
 	}
 
 	ret = ctrl->xfer_msg(ctrl, txn);

Original file line number	Diff line number	Diff line change
`@@ -143,8 +143,6 @@ int slim_do_transfer(struct slim_controller ctrl, struct slim_msg_txn txn)`
`143`	`143`
`144`	`144`	`if (!txn->msg->comp)`
`145`	`145`	`txn->comp = &done;`
`146`		`- else`
`147`		`- txn->comp = txn->comp;`
`148`	`146`	`}`
`149`	`147`
`150`	`148`	`ret = ctrl->xfer_msg(ctrl, txn);`