Skip to content

Commit 5d54aa4

Browse files
mmhalPaolo Abeni
authored andcommitted
vsock/test: Do not filter kallsyms by symbol type
Blamed commit implemented logic to discover available vsock transports by grepping /proc/kallsyms for known symbols. It incorrectly filtered entries by type 'd'. For some kernel configs having CONFIG_VIRTIO_VSOCKETS=m CONFIG_VSOCKETS_LOOPBACK=y kallsyms reports 0000000000000000 d virtio_transport [vmw_vsock_virtio_transport] 0000000000000000 t loopback_transport Overzealous filtering might have affected vsock test suit, resulting in insufficient/misleading testing. Do not filter symbols by type. It never helped much. Fixes: 3070c05 ("vsock/test: Introduce get_transports()") Signed-off-by: Michal Luczaj <mhal@rbox.co> Reviewed-by: Stefano Garzarella <sgarzare@redhat.com> Link: https://patch.msgid.link/20260116-vsock_test-kallsyms-grep-v1-1-3320bc3346f2@rbox.co Signed-off-by: Paolo Abeni <pabeni@redhat.com>
1 parent 58bae91 commit 5d54aa4

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

tools/testing/vsock/util.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ enum transport {
2525
};
2626

2727
static const char * const transport_ksyms[] = {
28-
#define x(name, symbol) "d " symbol "_transport",
28+
#define x(name, symbol) " " symbol "_transport",
2929
KNOWN_TRANSPORTS(x)
3030
#undef x
3131
};

0 commit comments

Comments
 (0)