Skip to content

Commit 5d93f7b

Browse files
isilenceaxboe
authored andcommitted
io_uring/zcrx: set sgt for umem area
Set struct io_zcrx_mem::sgt for umem areas as well to simplify looking up the current sg table. Signed-off-by: Pavel Begunkov <asml.silence@gmail.com> Signed-off-by: Jens Axboe <axboe@kernel.dk>
1 parent 6c18511 commit 5d93f7b

2 files changed

Lines changed: 7 additions & 9 deletions

File tree

io_uring/zcrx.c

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -52,9 +52,9 @@ static inline struct page *io_zcrx_iov_page(const struct net_iov *niov)
5252
}
5353

5454
static int io_populate_area_dma(struct io_zcrx_ifq *ifq,
55-
struct io_zcrx_area *area,
56-
struct sg_table *sgt)
55+
struct io_zcrx_area *area)
5756
{
57+
struct sg_table *sgt = area->mem.sgt;
5858
struct scatterlist *sg;
5959
unsigned i, niov_idx = 0;
6060

@@ -197,6 +197,7 @@ static int io_import_umem(struct io_zcrx_ifq *ifq,
197197
if (ret < 0)
198198
mem->account_pages = 0;
199199

200+
mem->sgt = &mem->page_sg_table;
200201
mem->pages = pages;
201202
mem->nr_folios = nr_pages;
202203
mem->size = area_reg->len;
@@ -211,7 +212,8 @@ static void io_release_area_mem(struct io_zcrx_mem *mem)
211212
}
212213
if (mem->pages) {
213214
unpin_user_pages(mem->pages, mem->nr_folios);
214-
sg_free_table(&mem->page_sg_table);
215+
sg_free_table(mem->sgt);
216+
mem->sgt = NULL;
215217
kvfree(mem->pages);
216218
}
217219
}
@@ -263,7 +265,6 @@ static void io_zcrx_unmap_area(struct io_zcrx_ifq *ifq,
263265

264266
static int io_zcrx_map_area(struct io_zcrx_ifq *ifq, struct io_zcrx_area *area)
265267
{
266-
struct sg_table *sgt;
267268
int ret;
268269

269270
guard(mutex)(&ifq->dma_lock);
@@ -275,12 +276,9 @@ static int io_zcrx_map_area(struct io_zcrx_ifq *ifq, struct io_zcrx_area *area)
275276
DMA_FROM_DEVICE, IO_DMA_ATTR);
276277
if (ret < 0)
277278
return ret;
278-
sgt = &area->mem.page_sg_table;
279-
} else {
280-
sgt = area->mem.sgt;
281279
}
282280

283-
ret = io_populate_area_dma(ifq, area, sgt);
281+
ret = io_populate_area_dma(ifq, area);
284282
if (ret == 0)
285283
area->is_mapped = true;
286284
return ret;

io_uring/zcrx.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,10 @@ struct io_zcrx_mem {
1616
unsigned long nr_folios;
1717
struct sg_table page_sg_table;
1818
unsigned long account_pages;
19+
struct sg_table *sgt;
1920

2021
struct dma_buf_attachment *attach;
2122
struct dma_buf *dmabuf;
22-
struct sg_table *sgt;
2323
};
2424

2525
struct io_zcrx_area {

0 commit comments

Comments
 (0)