lib/crc: Drop inline from all *_mod_init_arch() functions

Eric Biggers · Eric Biggers · commit 5ff74f5f71f8 · 2025-08-15T19:06:08.000-07:00
Drop 'inline' from all the *_mod_init_arch() functions so that the compiler will warn about any bugs where they are unused due to not being wired up properly. (There are no such bugs currently, so this just establishes a more robust convention for the future. Of course, these functions also tend to get inlined anyway, regardless of the keyword.) Link: https://lore.kernel.org/r/20250816020240.431545-1-ebiggers@kernel.org Signed-off-by: Eric Biggers <ebiggers@kernel.org>
diff --git a/lib/crc/arm/crc-t10dif.h b/lib/crc/arm/crc-t10dif.h
@@ -43,7 +43,7 @@ static inline u16 crc_t10dif_arch(u16 crc, const u8 *data, size_t length)
 }
 
 #define crc_t10dif_mod_init_arch crc_t10dif_mod_init_arch
-static inline void crc_t10dif_mod_init_arch(void)
+static void crc_t10dif_mod_init_arch(void)
 {
 	if (elf_hwcap & HWCAP_NEON) {
 		static_branch_enable(&have_neon);
diff --git a/lib/crc/arm/crc32.h b/lib/crc/arm/crc32.h
@@ -83,7 +83,7 @@ static inline u32 crc32c_arch(u32 crc, const u8 *p, size_t len)
 #define crc32_be_arch crc32_be_base /* not implemented on this arch */
 
 #define crc32_mod_init_arch crc32_mod_init_arch
-static inline void crc32_mod_init_arch(void)
+static void crc32_mod_init_arch(void)
 {
 	if (elf_hwcap2 & HWCAP2_CRC32)
 		static_branch_enable(&have_crc32);
diff --git a/lib/crc/arm64/crc-t10dif.h b/lib/crc/arm64/crc-t10dif.h
@@ -45,7 +45,7 @@ static inline u16 crc_t10dif_arch(u16 crc, const u8 *data, size_t length)
 }
 
 #define crc_t10dif_mod_init_arch crc_t10dif_mod_init_arch
-static inline void crc_t10dif_mod_init_arch(void)
+static void crc_t10dif_mod_init_arch(void)
 {
 	if (cpu_have_named_feature(ASIMD)) {
 		static_branch_enable(&have_asimd);
diff --git a/lib/crc/loongarch/crc32.h b/lib/crc/loongarch/crc32.h
@@ -101,7 +101,7 @@ static inline u32 crc32c_arch(u32 crc, const u8 *p, size_t len)
 #define crc32_be_arch crc32_be_base /* not implemented on this arch */
 
 #define crc32_mod_init_arch crc32_mod_init_arch
-static inline void crc32_mod_init_arch(void)
+static void crc32_mod_init_arch(void)
 {
 	if (cpu_has_crc32)
 		static_branch_enable(&have_crc32);
diff --git a/lib/crc/mips/crc32.h b/lib/crc/mips/crc32.h
@@ -148,7 +148,7 @@ static inline u32 crc32c_arch(u32 crc, const u8 *p, size_t len)
 #define crc32_be_arch crc32_be_base /* not implemented on this arch */
 
 #define crc32_mod_init_arch crc32_mod_init_arch
-static inline void crc32_mod_init_arch(void)
+static void crc32_mod_init_arch(void)
 {
 	if (cpu_have_feature(cpu_feature(MIPS_CRC32)))
 		static_branch_enable(&have_crc32);
diff --git a/lib/crc/powerpc/crc-t10dif.h b/lib/crc/powerpc/crc-t10dif.h
@@ -62,7 +62,7 @@ static inline u16 crc_t10dif_arch(u16 crci, const u8 *p, size_t len)
 }
 
 #define crc_t10dif_mod_init_arch crc_t10dif_mod_init_arch
-static inline void crc_t10dif_mod_init_arch(void)
+static void crc_t10dif_mod_init_arch(void)
 {
 	if (cpu_has_feature(CPU_FTR_ARCH_207S) &&
 	    (cur_cpu_spec->cpu_user_features2 & PPC_FEATURE2_VEC_CRYPTO))
diff --git a/lib/crc/powerpc/crc32.h b/lib/crc/powerpc/crc32.h
@@ -55,7 +55,7 @@ static inline u32 crc32c_arch(u32 crc, const u8 *p, size_t len)
 }
 
 #define crc32_mod_init_arch crc32_mod_init_arch
-static inline void crc32_mod_init_arch(void)
+static void crc32_mod_init_arch(void)
 {
 	if (cpu_has_feature(CPU_FTR_ARCH_207S) &&
 	    (cur_cpu_spec->cpu_user_features2 & PPC_FEATURE2_VEC_CRYPTO))
diff --git a/lib/crc/sparc/crc32.h b/lib/crc/sparc/crc32.h
@@ -44,7 +44,7 @@ static inline u32 crc32c_arch(u32 crc, const u8 *data, size_t len)
 }
 
 #define crc32_mod_init_arch crc32_mod_init_arch
-static inline void crc32_mod_init_arch(void)
+static void crc32_mod_init_arch(void)
 {
 	unsigned long cfr;
 
diff --git a/lib/crc/x86/crc-t10dif.h b/lib/crc/x86/crc-t10dif.h
@@ -19,7 +19,7 @@ static inline u16 crc_t10dif_arch(u16 crc, const u8 *p, size_t len)
 }
 
 #define crc_t10dif_mod_init_arch crc_t10dif_mod_init_arch
-static inline void crc_t10dif_mod_init_arch(void)
+static void crc_t10dif_mod_init_arch(void)
 {
 	if (boot_cpu_has(X86_FEATURE_PCLMULQDQ)) {
 		static_branch_enable(&have_pclmulqdq);
diff --git a/lib/crc/x86/crc32.h b/lib/crc/x86/crc32.h
@@ -106,7 +106,7 @@ static inline u32 crc32c_arch(u32 crc, const u8 *p, size_t len)
 #define crc32_be_arch crc32_be_base /* not implemented on this arch */
 
 #define crc32_mod_init_arch crc32_mod_init_arch
-static inline void crc32_mod_init_arch(void)
+static void crc32_mod_init_arch(void)
 {
 	if (boot_cpu_has(X86_FEATURE_XMM4_2))
 		static_branch_enable(&have_crc32);
diff --git a/lib/crc/x86/crc64.h b/lib/crc/x86/crc64.h
@@ -27,7 +27,7 @@ static inline u64 crc64_nvme_arch(u64 crc, const u8 *p, size_t len)
 }
 
 #define crc64_mod_init_arch crc64_mod_init_arch
-static inline void crc64_mod_init_arch(void)
+static void crc64_mod_init_arch(void)
 {
 	if (boot_cpu_has(X86_FEATURE_PCLMULQDQ)) {
 		static_branch_enable(&have_pclmulqdq);

Original file line number	Diff line number	Diff line change
`@@ -43,7 +43,7 @@ static inline u16 crc_t10dif_arch(u16 crc, const u8 *data, size_t length)`
`43`	`43`	`}`
`44`	`44`
`45`	`45`	`#define crc_t10dif_mod_init_arch crc_t10dif_mod_init_arch`
`46`		`-static inline void crc_t10dif_mod_init_arch(void)`
	`46`	`+static void crc_t10dif_mod_init_arch(void)`
`47`	`47`	`{`
`48`	`48`	`if (elf_hwcap & HWCAP_NEON) {`
`49`	`49`	`static_branch_enable(&have_neon);`
Original file line number	Diff line number	Diff line change
`@@ -83,7 +83,7 @@ static inline u32 crc32c_arch(u32 crc, const u8 *p, size_t len)`
`83`	`83`	`#define crc32_be_arch crc32_be_base /* not implemented on this arch */`
`84`	`84`
`85`	`85`	`#define crc32_mod_init_arch crc32_mod_init_arch`
`86`		`-static inline void crc32_mod_init_arch(void)`
	`86`	`+static void crc32_mod_init_arch(void)`
`87`	`87`	`{`
`88`	`88`	`if (elf_hwcap2 & HWCAP2_CRC32)`
`89`	`89`	`static_branch_enable(&have_crc32);`
Original file line number	Diff line number	Diff line change
`@@ -45,7 +45,7 @@ static inline u16 crc_t10dif_arch(u16 crc, const u8 *data, size_t length)`
`45`	`45`	`}`
`46`	`46`
`47`	`47`	`#define crc_t10dif_mod_init_arch crc_t10dif_mod_init_arch`
`48`		`-static inline void crc_t10dif_mod_init_arch(void)`
	`48`	`+static void crc_t10dif_mod_init_arch(void)`
`49`	`49`	`{`
`50`	`50`	`if (cpu_have_named_feature(ASIMD)) {`
`51`	`51`	`static_branch_enable(&have_asimd);`
Original file line number	Diff line number	Diff line change
`@@ -101,7 +101,7 @@ static inline u32 crc32c_arch(u32 crc, const u8 *p, size_t len)`
`101`	`101`	`#define crc32_be_arch crc32_be_base /* not implemented on this arch */`
`102`	`102`
`103`	`103`	`#define crc32_mod_init_arch crc32_mod_init_arch`
`104`		`-static inline void crc32_mod_init_arch(void)`
	`104`	`+static void crc32_mod_init_arch(void)`
`105`	`105`	`{`
`106`	`106`	`if (cpu_has_crc32)`
`107`	`107`	`static_branch_enable(&have_crc32);`
Original file line number	Diff line number	Diff line change
`@@ -148,7 +148,7 @@ static inline u32 crc32c_arch(u32 crc, const u8 *p, size_t len)`
`148`	`148`	`#define crc32_be_arch crc32_be_base /* not implemented on this arch */`
`149`	`149`
`150`	`150`	`#define crc32_mod_init_arch crc32_mod_init_arch`
`151`		`-static inline void crc32_mod_init_arch(void)`
	`151`	`+static void crc32_mod_init_arch(void)`
`152`	`152`	`{`
`153`	`153`	`if (cpu_have_feature(cpu_feature(MIPS_CRC32)))`
`154`	`154`	`static_branch_enable(&have_crc32);`
Original file line number	Diff line number	Diff line change
`@@ -62,7 +62,7 @@ static inline u16 crc_t10dif_arch(u16 crci, const u8 *p, size_t len)`
`62`	`62`	`}`
`63`	`63`
`64`	`64`	`#define crc_t10dif_mod_init_arch crc_t10dif_mod_init_arch`
`65`		`-static inline void crc_t10dif_mod_init_arch(void)`
	`65`	`+static void crc_t10dif_mod_init_arch(void)`
`66`	`66`	`{`
`67`	`67`	`if (cpu_has_feature(CPU_FTR_ARCH_207S) &&`
`68`	`68`	`(cur_cpu_spec->cpu_user_features2 & PPC_FEATURE2_VEC_CRYPTO))`
Original file line number	Diff line number	Diff line change
`@@ -55,7 +55,7 @@ static inline u32 crc32c_arch(u32 crc, const u8 *p, size_t len)`
`55`	`55`	`}`
`56`	`56`
`57`	`57`	`#define crc32_mod_init_arch crc32_mod_init_arch`
`58`		`-static inline void crc32_mod_init_arch(void)`
	`58`	`+static void crc32_mod_init_arch(void)`
`59`	`59`	`{`
`60`	`60`	`if (cpu_has_feature(CPU_FTR_ARCH_207S) &&`
`61`	`61`	`(cur_cpu_spec->cpu_user_features2 & PPC_FEATURE2_VEC_CRYPTO))`
Original file line number	Diff line number	Diff line change
`@@ -44,7 +44,7 @@ static inline u32 crc32c_arch(u32 crc, const u8 *data, size_t len)`
`44`	`44`	`}`
`45`	`45`
`46`	`46`	`#define crc32_mod_init_arch crc32_mod_init_arch`
`47`		`-static inline void crc32_mod_init_arch(void)`
	`47`	`+static void crc32_mod_init_arch(void)`
`48`	`48`	`{`
`49`	`49`	`unsigned long cfr;`
`50`	`50`
Original file line number	Diff line number	Diff line change
`@@ -19,7 +19,7 @@ static inline u16 crc_t10dif_arch(u16 crc, const u8 *p, size_t len)`
`19`	`19`	`}`
`20`	`20`
`21`	`21`	`#define crc_t10dif_mod_init_arch crc_t10dif_mod_init_arch`
`22`		`-static inline void crc_t10dif_mod_init_arch(void)`
	`22`	`+static void crc_t10dif_mod_init_arch(void)`
`23`	`23`	`{`
`24`	`24`	`if (boot_cpu_has(X86_FEATURE_PCLMULQDQ)) {`
`25`	`25`	`static_branch_enable(&have_pclmulqdq);`
Original file line number	Diff line number	Diff line change
`@@ -106,7 +106,7 @@ static inline u32 crc32c_arch(u32 crc, const u8 *p, size_t len)`
`106`	`106`	`#define crc32_be_arch crc32_be_base /* not implemented on this arch */`
`107`	`107`
`108`	`108`	`#define crc32_mod_init_arch crc32_mod_init_arch`
`109`		`-static inline void crc32_mod_init_arch(void)`
	`109`	`+static void crc32_mod_init_arch(void)`
`110`	`110`	`{`
`111`	`111`	`if (boot_cpu_has(X86_FEATURE_XMM4_2))`
`112`	`112`	`static_branch_enable(&have_crc32);`