Skip to content

Commit 6073229

Browse files
svenpeter42joergroedel
authored andcommitted
iommu/apple-dart: Use readl instead of readl_relaxed for consistency
While the readl_relaxed in apple_dart_suspend is correct the rest of the driver uses the non-relaxed variants everywhere and the single readl_relaxed is inconsistent and possibly confusing. Signed-off-by: Sven Peter <sven@svenpeter.dev> Acked-by: Hector Martin <marcan@marcan.st> Reviewed-by: Neal Gompa <neal@gompa.dev> Link: https://lore.kernel.org/r/20231126162009.17934-1-sven@svenpeter.dev Signed-off-by: Joerg Roedel <jroedel@suse.de>
1 parent 863c092 commit 6073229

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/iommu/apple-dart.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1302,7 +1302,7 @@ static __maybe_unused int apple_dart_suspend(struct device *dev)
13021302
unsigned int sid, idx;
13031303

13041304
for (sid = 0; sid < dart->num_streams; sid++) {
1305-
dart->save_tcr[sid] = readl_relaxed(dart->regs + DART_TCR(dart, sid));
1305+
dart->save_tcr[sid] = readl(dart->regs + DART_TCR(dart, sid));
13061306
for (idx = 0; idx < dart->hw->ttbr_count; idx++)
13071307
dart->save_ttbr[sid][idx] =
13081308
readl(dart->regs + DART_TTBR(dart, sid, idx));

0 commit comments

Comments
 (0)