Skip to content

Commit 612b1df

Browse files
nmenonherbertx
authored andcommitted
hwrng: ks-sa - fix division by zero in ks_sa_rng_init
Fix division by zero in ks_sa_rng_init caused by missing clock pointer initialization. The clk_get_rate() call is performed on an uninitialized clk pointer, resulting in division by zero when calculating delay values. Add clock initialization code before using the clock. Fixes: 6d01d85 ("hwrng: ks-sa - Add minimum sleep time before ready-polling") Signed-off-by: Nishanth Menon <nm@ti.com> drivers/char/hw_random/ks-sa-rng.c | 7 +++++++ 1 file changed, 7 insertions(+) Reviewed-by: Alexander Sverdlin <alexander.sverdlin@gmail.com> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
1 parent 5851aff commit 612b1df

1 file changed

Lines changed: 4 additions & 0 deletions

File tree

drivers/char/hw_random/ks-sa-rng.c

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -231,6 +231,10 @@ static int ks_sa_rng_probe(struct platform_device *pdev)
231231
if (IS_ERR(ks_sa_rng->regmap_cfg))
232232
return dev_err_probe(dev, -EINVAL, "syscon_node_to_regmap failed\n");
233233

234+
ks_sa_rng->clk = devm_clk_get_enabled(dev, NULL);
235+
if (IS_ERR(ks_sa_rng->clk))
236+
return dev_err_probe(dev, PTR_ERR(ks_sa_rng->clk), "Failed to get clock\n");
237+
234238
pm_runtime_enable(dev);
235239
ret = pm_runtime_resume_and_get(dev);
236240
if (ret < 0) {

0 commit comments

Comments
 (0)