Skip to content

Commit 62d6b81

Browse files
arndbsudeep-holla
authored andcommitted
firmware: arm_scmi: Convert to SYSTEM_SLEEP_PM_OPS
The old SET_SYSTEM_SLEEP_PM_OPS() macro leads to a warning about an unused function: | drivers/firmware/arm_scmi/scmi_power_control.c:363:12: error: | 'scmi_system_power_resume' defined but not used [-Werror=unused-function] | static int scmi_system_power_resume(struct device *dev) The proper way to do this these days is to use SYSTEM_SLEEP_PM_OPS() and pm_sleep_ptr(). Fixes: 9a0658d ("firmware: arm_scmi: power_control: Ensure SCMI_SYSPOWER_IDLE is set early during resume") Signed-off-by: Arnd Bergmann <arnd@arndb.de> Acked-by: Peng Fan <peng.fan@nxp.com> Message-Id: <20250709070107.1388512-1-arnd@kernel.org> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
1 parent b5daf93 commit 62d6b81

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

drivers/firmware/arm_scmi/scmi_power_control.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -369,7 +369,7 @@ static int scmi_system_power_resume(struct device *dev)
369369
}
370370

371371
static const struct dev_pm_ops scmi_system_power_pmops = {
372-
SET_SYSTEM_SLEEP_PM_OPS(NULL, scmi_system_power_resume)
372+
SYSTEM_SLEEP_PM_OPS(NULL, scmi_system_power_resume)
373373
};
374374

375375
static const struct scmi_device_id scmi_id_table[] = {
@@ -380,7 +380,7 @@ MODULE_DEVICE_TABLE(scmi, scmi_id_table);
380380

381381
static struct scmi_driver scmi_system_power_driver = {
382382
.driver = {
383-
.pm = &scmi_system_power_pmops,
383+
.pm = pm_sleep_ptr(&scmi_system_power_pmops),
384384
},
385385
.name = "scmi-system-power",
386386
.probe = scmi_syspower_probe,

0 commit comments

Comments
 (0)