Skip to content

Commit 66990c0

Browse files
committed
scripts/sorttable: Have the ORC code use the _r() functions to read
The ORC code reads the section information directly from the file. This currently works because the default read function is for 64bit little endian machines. But if for some reason that ever changes, this will break. Instead of having a surprise breakage, use the _r() functions that will read the values from the file properly. Cc: bpf <bpf@vger.kernel.org> Cc: Masami Hiramatsu <mhiramat@kernel.org> Cc: Mark Rutland <mark.rutland@arm.com> Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com> Cc: Andrew Morton <akpm@linux-foundation.org> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Linus Torvalds <torvalds@linux-foundation.org> Cc: Masahiro Yamada <masahiroy@kernel.org> Cc: Nathan Chancellor <nathan@kernel.org> Cc: Nicolas Schier <nicolas@fjasle.eu> Cc: Zheng Yejian <zhengyejian1@huawei.com> Cc: Martin Kelly <martin.kelly@crowdstrike.com> Cc: Christophe Leroy <christophe.leroy@csgroup.eu> Cc: Josh Poimboeuf <jpoimboe@redhat.com> Link: https://lore.kernel.org/20250105162344.721480386@goodmis.org Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
1 parent 6f2c2f9 commit 66990c0

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

scripts/sorttable.h

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -299,14 +299,14 @@ static int do_sort(Elf_Ehdr *ehdr,
299299
#if defined(SORTTABLE_64) && defined(UNWINDER_ORC_ENABLED)
300300
/* locate the ORC unwind tables */
301301
if (!strcmp(secstrings + idx, ".orc_unwind_ip")) {
302-
orc_ip_size = s->sh_size;
302+
orc_ip_size = _r(&s->sh_size);
303303
g_orc_ip_table = (int *)((void *)ehdr +
304-
s->sh_offset);
304+
_r(&s->sh_offset));
305305
}
306306
if (!strcmp(secstrings + idx, ".orc_unwind")) {
307-
orc_size = s->sh_size;
307+
orc_size = _r(&s->sh_size);
308308
g_orc_table = (struct orc_entry *)((void *)ehdr +
309-
s->sh_offset);
309+
_r(&s->sh_offset));
310310
}
311311
#endif
312312
} /* for loop */

0 commit comments

Comments
 (0)