ata: ahci_imx: Fix error code in probe()

Dan Carpenter · floatious · commit 66afec7c6992 · 2024-08-15T13:44:33.000+02:00
Return a negative error code if devm_clk_get() fails. Don't return success. Fixes: 3156e1b ("ata: ahci_imx: AHB clock rate setting is not required on i.MX8QM AHCI SATA") Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> Link: https://lore.kernel.org/r/cbcbdfc2-ddc7-4684-8ad4-018227823546@stanley.mountain Signed-off-by: Niklas Cassel <cassel@kernel.org>
diff --git a/drivers/ata/ahci_imx.c b/drivers/ata/ahci_imx.c
@@ -963,6 +963,7 @@ static int imx_ahci_probe(struct platform_device *pdev)
 		imxpriv->ahb_clk = devm_clk_get(dev, "ahb");
 		if (IS_ERR(imxpriv->ahb_clk)) {
 			dev_err(dev, "Failed to get ahb clock\n");
+			ret = PTR_ERR(imxpriv->ahb_clk);
 			goto disable_sata;
 		}
 		reg_val = clk_get_rate(imxpriv->ahb_clk) / 1000;

Original file line number	Diff line number	Diff line change
`@@ -963,6 +963,7 @@ static int imx_ahci_probe(struct platform_device *pdev)`
`963`	`963`	`imxpriv->ahb_clk = devm_clk_get(dev, "ahb");`
`964`	`964`	`if (IS_ERR(imxpriv->ahb_clk)) {`
`965`	`965`	`dev_err(dev, "Failed to get ahb clock\n");`
	`966`	`+ ret = PTR_ERR(imxpriv->ahb_clk);`
`966`	`967`	`goto disable_sata;`
`967`	`968`	`}`
`968`	`969`	`reg_val = clk_get_rate(imxpriv->ahb_clk) / 1000;`