Skip to content

Commit 66e9feb

Browse files
Hans de Goedebroonie
authored andcommitted
spi: Add TODO comment about ACPI GPIO setup
Add a TODO comment that ideally the ACPI/gpiolib core code should take care of setting GPIO direction and/or bias according to ACPI GPIO resources. If this TODO gets implemented then the acpi_dev_gpio_irq_get() call in acpi_register_spi_device() can be dropped. Suggested-by: Andy Shevchenko <andy@kernel.org> Signed-off-by: Hans de Goede <johannes.goede@oss.qualcomm.com> Reviewed-by: Andy Shevchenko <andy@kernel.org> Link: https://patch.msgid.link/20251109155340.26199-1-johannes.goede@oss.qualcomm.com Signed-off-by: Mark Brown <broonie@kernel.org>
1 parent 939edfa commit 66e9feb

1 file changed

Lines changed: 2 additions & 0 deletions

File tree

drivers/spi/spi.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2857,6 +2857,8 @@ static acpi_status acpi_register_spi_device(struct spi_controller *ctlr,
28572857
* here too, because this call sets the GPIO direction and/or bias.
28582858
* Setting these needs to be done even if there is no driver, in which
28592859
* case spi_probe() will never get called.
2860+
* TODO: ideally the setup of the GPIO should be handled in a generic
2861+
* manner in the ACPI/gpiolib core code.
28602862
*/
28612863
if (spi->irq < 0)
28622864
spi->irq = acpi_dev_gpio_irq_get(adev, 0);

0 commit comments

Comments
 (0)