Skip to content

Commit 69cc2e1

Browse files
Sasha Levingregkh
authored andcommitted
arm64: dts: qcom: x1e78100-t14s: fix missing HID supplies
[ Upstream commit 55e52d0 ] Add the missing HID supplies to avoid relying on other consumers to keep them on. This also avoids the following warnings on boot: i2c_hid_of 0-0010: supply vdd not found, using dummy regulator i2c_hid_of 0-0010: supply vddl not found, using dummy regulator i2c_hid_of 1-0015: supply vdd not found, using dummy regulator i2c_hid_of 1-002c: supply vdd not found, using dummy regulator i2c_hid_of 1-0015: supply vddl not found, using dummy regulator i2c_hid_of 1-002c: supply vddl not found, using dummy regulator i2c_hid_of 1-003a: supply vdd not found, using dummy regulator i2c_hid_of 1-003a: supply vddl not found, using dummy regulator Note that VCC3B is also used for things like the modem which are not yet described so mark the regulator as always-on for now. Fixes: 7d1cbe2 ("arm64: dts: qcom: Add X1E78100 ThinkPad T14s Gen 6") Cc: stable@vger.kernel.org # 6.12 Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> Signed-off-by: Johan Hovold <johan+linaro@kernel.org> Link: https://lore.kernel.org/r/20250314145440.11371-9-johan+linaro@kernel.org Signed-off-by: Bjorn Andersson <andersson@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>
1 parent a5b9137 commit 69cc2e1

1 file changed

Lines changed: 43 additions & 0 deletions

File tree

arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dts

Lines changed: 43 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
#include <dt-bindings/gpio/gpio.h>
1010
#include <dt-bindings/input/gpio-keys.h>
1111
#include <dt-bindings/input/input.h>
12+
#include <dt-bindings/pinctrl/qcom,pmic-gpio.h>
1213
#include <dt-bindings/regulator/qcom,rpmh-regulator.h>
1314

1415
#include "x1e80100.dtsi"
@@ -153,6 +154,23 @@
153154
regulator-boot-on;
154155
};
155156

157+
vreg_misc_3p3: regulator-misc-3p3 {
158+
compatible = "regulator-fixed";
159+
160+
regulator-name = "VCC3B";
161+
regulator-min-microvolt = <3300000>;
162+
regulator-max-microvolt = <3300000>;
163+
164+
gpio = <&pm8550ve_8_gpios 6 GPIO_ACTIVE_HIGH>;
165+
enable-active-high;
166+
167+
pinctrl-0 = <&misc_3p3_reg_en>;
168+
pinctrl-names = "default";
169+
170+
regulator-boot-on;
171+
regulator-always-on;
172+
};
173+
156174
vreg_nvme: regulator-nvme {
157175
compatible = "regulator-fixed";
158176

@@ -580,6 +598,9 @@
580598
hid-descr-addr = <0x1>;
581599
interrupts-extended = <&tlmm 3 IRQ_TYPE_LEVEL_LOW>;
582600

601+
vdd-supply = <&vreg_misc_3p3>;
602+
vddl-supply = <&vreg_l12b_1p2>;
603+
583604
wakeup-source;
584605
};
585606

@@ -591,6 +612,9 @@
591612
hid-descr-addr = <0x20>;
592613
interrupts-extended = <&tlmm 3 IRQ_TYPE_LEVEL_LOW>;
593614

615+
vdd-supply = <&vreg_misc_3p3>;
616+
vddl-supply = <&vreg_l12b_1p2>;
617+
594618
wakeup-source;
595619
};
596620

@@ -602,6 +626,9 @@
602626
hid-descr-addr = <0x1>;
603627
interrupts-extended = <&tlmm 67 IRQ_TYPE_LEVEL_LOW>;
604628

629+
vdd-supply = <&vreg_misc_3p3>;
630+
vddl-supply = <&vreg_l15b_1p8>;
631+
605632
pinctrl-0 = <&kybd_default>;
606633
pinctrl-names = "default";
607634

@@ -670,6 +697,9 @@
670697
hid-descr-addr = <0x1>;
671698
interrupts-extended = <&tlmm 51 IRQ_TYPE_LEVEL_LOW>;
672699

700+
vdd-supply = <&vreg_misc_3p3>;
701+
vddl-supply = <&vreg_l15b_1p8>;
702+
673703
pinctrl-0 = <&ts0_default>;
674704
pinctrl-names = "default";
675705
};
@@ -789,6 +819,19 @@
789819
};
790820
};
791821

822+
&pm8550ve_8_gpios {
823+
misc_3p3_reg_en: misc-3p3-reg-en-state {
824+
pins = "gpio6";
825+
function = "normal";
826+
bias-disable;
827+
drive-push-pull;
828+
input-disable;
829+
output-enable;
830+
power-source = <1>; /* 1.8 V */
831+
qcom,drive-strength = <PMIC_GPIO_STRENGTH_LOW>;
832+
};
833+
};
834+
792835
&qupv3_0 {
793836
status = "okay";
794837
};

0 commit comments

Comments
 (0)