perf mem-events: Don't leak online CPU map

captain5050 · namhyung · commit 69d247295a51 · 2025-12-03T11:07:46.000-08:00
Reference count checking found the online CPU map was being gotten but
not put. Add in the missing put.

Signed-off-by: Ian Rogers &lt;irogers@google.com&gt;
Reviewed-by: Arnaldo Carvalho de Melo &lt;acme@redhat.com&gt;
Signed-off-by: Namhyung Kim &lt;namhyung@kernel.org&gt;
diff --git a/tools/perf/util/mem-events.c b/tools/perf/util/mem-events.c
@@ -303,12 +303,15 @@ int perf_mem_events__record_args(const char **rec_argv, int *argv_nr, char **eve
 	}
 
 	if (cpu_map) {
-		if (!perf_cpu_map__equal(cpu_map, cpu_map__online())) {
+		struct perf_cpu_map *online = cpu_map__online();
+
+		if (!perf_cpu_map__equal(cpu_map, online)) {
 			char buf[200];
 
 			cpu_map__snprint(cpu_map, buf, sizeof(buf));
 			pr_warning("Memory events are enabled on a subset of CPUs: %s\n", buf);
 		}
+		perf_cpu_map__put(online);
 		perf_cpu_map__put(cpu_map);
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -303,12 +303,15 @@ int perf_mem_events__record_args(const char *rec_argv, int argv_nr, char **eve`
`303`	`303`	`}`
`304`	`304`
`305`	`305`	`if (cpu_map) {`
`306`		`- if (!perf_cpu_map__equal(cpu_map, cpu_map__online())) {`
	`306`	`+ struct perf_cpu_map *online = cpu_map__online();`
	`307`	`+`
	`308`	`+ if (!perf_cpu_map__equal(cpu_map, online)) {`
`307`	`309`	`char buf[200];`
`308`	`310`
`309`	`311`	`cpu_map__snprint(cpu_map, buf, sizeof(buf));`
`310`	`312`	`pr_warning("Memory events are enabled on a subset of CPUs: %s\n", buf);`
`311`	`313`	`}`
	`314`	`+ perf_cpu_map__put(online);`
`312`	`315`	`perf_cpu_map__put(cpu_map);`
`313`	`316`	`}`
`314`	`317`