Skip to content

Commit 6a13057

Browse files
tamirdojeda
authored andcommitted
rust: list: use fully qualified path
Use a fully qualified path rooted at `$crate` rather than relying on imports in the invoking scope. Tested-by: Alice Ryhl <aliceryhl@google.com> Reviewed-by: Alice Ryhl <aliceryhl@google.com> Signed-off-by: Tamir Duberstein <tamird@gmail.com> Link: https://lore.kernel.org/r/20250709-list-no-offset-v4-4-a429e75840a9@gmail.com Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
1 parent 9e626ed commit 6a13057

1 file changed

Lines changed: 5 additions & 5 deletions

File tree

rust/kernel/list/impl_list_item_mod.rs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,6 @@
44

55
//! Helpers for implementing list traits safely.
66
7-
use crate::list::ListLinks;
8-
97
/// Declares that this type has a `ListLinks<ID>` field at a fixed offset.
108
///
119
/// This trait is only used to help implement `ListItem` safely. If `ListItem` is implemented
@@ -27,11 +25,11 @@ pub unsafe trait HasListLinks<const ID: u64 = 0> {
2725
///
2826
/// The provided pointer must point at a valid struct of type `Self`.
2927
///
30-
/// [`ListLinks<T, ID>`]: ListLinks
28+
/// [`ListLinks<T, ID>`]: crate::list::ListLinks
3129
// We don't really need this method, but it's necessary for the implementation of
3230
// `impl_has_list_links!` to be correct.
3331
#[inline]
34-
unsafe fn raw_get_list_links(ptr: *mut Self) -> *mut ListLinks<ID> {
32+
unsafe fn raw_get_list_links(ptr: *mut Self) -> *mut crate::list::ListLinks<ID> {
3533
// SAFETY: The caller promises that the pointer is valid. The implementer promises that the
3634
// `OFFSET` constant is correct.
3735
unsafe { ptr.cast::<u8>().add(Self::OFFSET).cast() }
@@ -222,7 +220,9 @@ macro_rules! impl_list_item {
222220
// this value is not in a list.
223221
unsafe fn view_links(me: *const Self) -> *mut $crate::list::ListLinks<$num> {
224222
// SAFETY: The caller promises that `me` points at a valid value of type `Self`.
225-
unsafe { <Self as HasListLinks<$num>>::raw_get_list_links(me.cast_mut()) }
223+
unsafe {
224+
<Self as $crate::list::HasListLinks<$num>>::raw_get_list_links(me.cast_mut())
225+
}
226226
}
227227

228228
// This function is also used as the implementation of `post_remove`, so the caller

0 commit comments

Comments
 (0)