bpf: Remove migrate_{disable,enable} in bpf_cpumask_release()

Hou Tao · Alexei Starovoitov · commit 6a52b965ab6f · 2025-01-08T18:06:37.000-08:00
When BPF program invokes bpf_cpumask_release(), the migration must have been disabled. When bpf_cpumask_release_dtor() invokes bpf_cpumask_release(), the caller bpf_obj_free_fields() also has disabled migration, therefore, it is OK to remove the unnecessary migrate_{disable|enable} pair in bpf_cpumask_release(). Signed-off-by: Hou Tao <houtao1@huawei.com> Link: https://lore.kernel.org/r/20250108010728.207536-13-houtao@huaweicloud.com Signed-off-by: Alexei Starovoitov <ast@kernel.org>
diff --git a/kernel/bpf/cpumask.c b/kernel/bpf/cpumask.c
@@ -91,9 +91,7 @@ __bpf_kfunc void bpf_cpumask_release(struct bpf_cpumask *cpumask)
 	if (!refcount_dec_and_test(&cpumask->usage))
 		return;
 
-	migrate_disable();
 	bpf_mem_cache_free_rcu(&bpf_cpumask_ma, cpumask);
-	migrate_enable();
 }
 
 __bpf_kfunc void bpf_cpumask_release_dtor(void *cpumask)

Original file line number	Diff line number	Diff line change
`@@ -91,9 +91,7 @@ __bpf_kfunc void bpf_cpumask_release(struct bpf_cpumask *cpumask)`
`91`	`91`	`if (!refcount_dec_and_test(&cpumask->usage))`
`92`	`92`	`return;`
`93`	`93`
`94`		`- migrate_disable();`
`95`	`94`	`bpf_mem_cache_free_rcu(&bpf_cpumask_ma, cpumask);`
`96`		`- migrate_enable();`
`97`	`95`	`}`
`98`	`96`
`99`	`97`	`__bpf_kfunc void bpf_cpumask_release_dtor(void *cpumask)`