ublk: get ubq from pdu in ublk_cmd_list_tw_cb()

calebsander · axboe · commit 6a87fc437a03 · 2025-03-28T16:15:43.000-06:00
Save a few pointer dereferences by obtaining struct ublk_queue *ubq from the ublk_uring_cmd_pdu instead of the request's mq_hctx. Signed-off-by: Caleb Sander Mateos <csander@purestorage.com> Link: https://lore.kernel.org/r/20250328180411.2696494-4-csander@purestorage.com Signed-off-by: Jens Axboe <axboe@kernel.dk>
diff --git a/drivers/block/ublk_drv.c b/drivers/block/ublk_drv.c
@@ -1287,7 +1287,7 @@ static void ublk_cmd_list_tw_cb(struct io_uring_cmd *cmd,
 {
 	struct ublk_uring_cmd_pdu *pdu = ublk_get_uring_cmd_pdu(cmd);
 	struct request *rq = pdu->req_list;
-	struct ublk_queue *ubq = rq->mq_hctx->driver_data;
+	struct ublk_queue *ubq = pdu->ubq;
 	struct request *next;
 
 	do {

Original file line number	Diff line number	Diff line change
`@@ -1287,7 +1287,7 @@ static void ublk_cmd_list_tw_cb(struct io_uring_cmd *cmd,`
`1287`	`1287`	`{`
`1288`	`1288`	`struct ublk_uring_cmd_pdu *pdu = ublk_get_uring_cmd_pdu(cmd);`
`1289`	`1289`	`struct request *rq = pdu->req_list;`
`1290`		`- struct ublk_queue *ubq = rq->mq_hctx->driver_data;`
	`1290`	`+ struct ublk_queue *ubq = pdu->ubq;`
`1291`	`1291`	`struct request *next;`
`1292`	`1292`
`1293`	`1293`	`do {`