Skip to content

Commit 6c6acc5

Browse files
Hawking Zhangalexdeucher
authored andcommitted
drm/amdgpu: Load ipkeymgr drv for psp v14
while DBG_DRV is renamed to HAD_DRV for psp v14, part of its APIs/functionality is moved to a new component named Ipkeymgr_Drv. Signed-off-by: Hawking Zhang <Hawking.Zhang@amd.com> Reviewed-by: Likun Gao <Likun.Gao@amd.com> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
1 parent 12b8b4e commit 6c6acc5

4 files changed

Lines changed: 28 additions & 1 deletion

File tree

drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2265,6 +2265,15 @@ static int psp_hw_start(struct psp_context *psp)
22652265
}
22662266
}
22672267

2268+
if ((is_psp_fw_valid(psp->ipkeymgr_drv)) &&
2269+
(psp->funcs->bootloader_load_ipkeymgr_drv != NULL)) {
2270+
ret = psp_bootloader_load_ipkeymgr_drv(psp);
2271+
if (ret) {
2272+
dev_err(adev->dev, "PSP load ipkeymgr_drv failed!\n");
2273+
return ret;
2274+
}
2275+
}
2276+
22682277
if ((is_psp_fw_valid(psp->sos)) &&
22692278
(psp->funcs->bootloader_load_sos != NULL)) {
22702279
ret = psp_bootloader_load_sos(psp);
@@ -3280,6 +3289,12 @@ static int parse_sos_bin_descriptor(struct psp_context *psp,
32803289
psp->ras_drv.size_bytes = le32_to_cpu(desc->size_bytes);
32813290
psp->ras_drv.start_addr = ucode_start_addr;
32823291
break;
3292+
case PSP_FW_TYPE_PSP_IPKEYMGR_DRV:
3293+
psp->ipkeymgr_drv.fw_version = le32_to_cpu(desc->fw_version);
3294+
psp->ipkeymgr_drv.feature_version = le32_to_cpu(desc->fw_version);
3295+
psp->ipkeymgr_drv.size_bytes = le32_to_cpu(desc->size_bytes);
3296+
psp->ipkeymgr_drv.start_addr = ucode_start_addr;
3297+
break;
32833298
default:
32843299
dev_warn(psp->adev->dev, "Unsupported PSP FW type: %d\n", desc->fw_type);
32853300
break;

drivers/gpu/drm/amd/amdgpu/amdgpu_psp.h

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,8 @@ enum psp_bootloader_cmd {
7474
PSP_BL__LOAD_SOCDRV = 0xB0000,
7575
PSP_BL__LOAD_DBGDRV = 0xC0000,
7676
PSP_BL__LOAD_INTFDRV = 0xD0000,
77-
PSP_BL__LOAD_RASDRV = 0xE0000,
77+
PSP_BL__LOAD_RASDRV = 0xE0000,
78+
PSP_BL__LOAD_IPKEYMGRDRV = 0xF0000,
7879
PSP_BL__DRAM_LONG_TRAIN = 0x100000,
7980
PSP_BL__DRAM_SHORT_TRAIN = 0x200000,
8081
PSP_BL__LOAD_TOS_SPL_TABLE = 0x10000000,
@@ -117,6 +118,7 @@ struct psp_funcs {
117118
int (*bootloader_load_intf_drv)(struct psp_context *psp);
118119
int (*bootloader_load_dbg_drv)(struct psp_context *psp);
119120
int (*bootloader_load_ras_drv)(struct psp_context *psp);
121+
int (*bootloader_load_ipkeymgr_drv)(struct psp_context *psp);
120122
int (*bootloader_load_sos)(struct psp_context *psp);
121123
int (*ring_create)(struct psp_context *psp,
122124
enum psp_ring_type ring_type);
@@ -336,6 +338,7 @@ struct psp_context {
336338
struct psp_bin_desc intf_drv;
337339
struct psp_bin_desc dbg_drv;
338340
struct psp_bin_desc ras_drv;
341+
struct psp_bin_desc ipkeymgr_drv;
339342

340343
/* tmr buffer */
341344
struct amdgpu_bo *tmr_bo;
@@ -424,6 +427,9 @@ struct amdgpu_psp_funcs {
424427
#define psp_bootloader_load_ras_drv(psp) \
425428
((psp)->funcs->bootloader_load_ras_drv ? \
426429
(psp)->funcs->bootloader_load_ras_drv((psp)) : 0)
430+
#define psp_bootloader_load_ipkeymgr_drv(psp) \
431+
((psp)->funcs->bootloader_load_ipkeymgr_drv ? \
432+
(psp)->funcs->bootloader_load_ipkeymgr_drv((psp)) : 0)
427433
#define psp_bootloader_load_sos(psp) \
428434
((psp)->funcs->bootloader_load_sos ? (psp)->funcs->bootloader_load_sos((psp)) : 0)
429435
#define psp_smu_reload_quirk(psp) \

drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -125,6 +125,7 @@ enum psp_fw_type {
125125
PSP_FW_TYPE_PSP_INTF_DRV,
126126
PSP_FW_TYPE_PSP_DBG_DRV,
127127
PSP_FW_TYPE_PSP_RAS_DRV,
128+
PSP_FW_TYPE_PSP_IPKEYMGR_DRV,
128129
PSP_FW_TYPE_MAX_INDEX,
129130
};
130131

drivers/gpu/drm/amd/amdgpu/psp_v14_0.c

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -177,6 +177,10 @@ static int psp_v14_0_bootloader_load_ras_drv(struct psp_context *psp)
177177
return psp_v14_0_bootloader_load_component(psp, &psp->ras_drv, PSP_BL__LOAD_RASDRV);
178178
}
179179

180+
static int psp_v14_0_bootloader_load_ipkeymgr_drv(struct psp_context *psp)
181+
{
182+
return psp_v14_0_bootloader_load_component(psp, &psp->ipkeymgr_drv, PSP_BL__LOAD_IPKEYMGRDRV);
183+
}
180184

181185
static int psp_v14_0_bootloader_load_sos(struct psp_context *psp)
182186
{
@@ -653,6 +657,7 @@ static const struct psp_funcs psp_v14_0_funcs = {
653657
.bootloader_load_intf_drv = psp_v14_0_bootloader_load_intf_drv,
654658
.bootloader_load_dbg_drv = psp_v14_0_bootloader_load_dbg_drv,
655659
.bootloader_load_ras_drv = psp_v14_0_bootloader_load_ras_drv,
660+
.bootloader_load_ipkeymgr_drv = psp_v14_0_bootloader_load_ipkeymgr_drv,
656661
.bootloader_load_sos = psp_v14_0_bootloader_load_sos,
657662
.ring_create = psp_v14_0_ring_create,
658663
.ring_stop = psp_v14_0_ring_stop,

0 commit comments

Comments
 (0)