Skip to content

Commit 6cb31fb

Browse files
rxrblntdz
authored andcommitted
drm/mgag200: Fix big-endian support
Unlike the original, deleted Matrox mga driver, the new mgag200 driver has the XRGB frame-buffer byte swapped on big-endian "RISC" systems. Fix by enabling byte swapping "PowerPC" OPMODE for any __BIG_ENDIAN config. Fixes: 414c453 ("mgag200: initial g200se driver (v2)") Signed-off-by: René Rebe <rene@exactco.de> Cc: stable@kernel.org Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> Link: https://patch.msgid.link/20251208.141827.965103015954471168.rene@exactco.de
1 parent a585c7e commit 6cb31fb

1 file changed

Lines changed: 25 additions & 0 deletions

File tree

drivers/gpu/drm/mgag200/mgag200_mode.c

Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -161,6 +161,30 @@ static void mgag200_set_startadd(struct mga_device *mdev,
161161
WREG_ECRT(0x00, crtcext0);
162162
}
163163

164+
/*
165+
* Set the opmode for the hardware swapper for Big-Endian processor
166+
* support for the frame buffer aperture and DMAWIN space.
167+
*/
168+
static void mgag200_set_datasiz(struct mga_device *mdev, u32 format)
169+
{
170+
#if defined(__BIG_ENDIAN)
171+
u32 opmode = RREG32(MGAREG_OPMODE);
172+
173+
opmode &= ~(GENMASK(17, 16) | GENMASK(9, 8) | GENMASK(3, 2));
174+
175+
/* Big-endian byte-swapping */
176+
switch (format) {
177+
case DRM_FORMAT_RGB565:
178+
opmode |= 0x10100;
179+
break;
180+
case DRM_FORMAT_XRGB8888:
181+
opmode |= 0x20200;
182+
break;
183+
}
184+
WREG32(MGAREG_OPMODE, opmode);
185+
#endif
186+
}
187+
164188
void mgag200_init_registers(struct mga_device *mdev)
165189
{
166190
u8 crtc11, misc;
@@ -496,6 +520,7 @@ void mgag200_primary_plane_helper_atomic_update(struct drm_plane *plane,
496520
struct drm_atomic_helper_damage_iter iter;
497521
struct drm_rect damage;
498522

523+
mgag200_set_datasiz(mdev, fb->format->format);
499524
drm_atomic_helper_damage_iter_init(&iter, old_plane_state, plane_state);
500525
drm_atomic_for_each_plane_damage(&iter, &damage) {
501526
mgag200_handle_damage(mdev, shadow_plane_state->data, fb, &damage);

0 commit comments

Comments
 (0)