Skip to content

Commit 6cdc4d4

Browse files
ISCAS-Vulabsre
authored andcommitted
power: supply: rt5033_charger: Fix device node reference leaks
The device node pointers `np_conn` and `np_edev`, obtained from of_parse_phandle() and of_get_parent() respectively, are not released. This results in a reference count leak. Add of_node_put() calls after the last use of these device nodes to properly release their references and fix the leaks. Fixes: 8242336 ("power: supply: rt5033_charger: Add cable detection and USB OTG supply") Signed-off-by: Haotian Zhang <vulab@iscas.ac.cn> Link: https://patch.msgid.link/20250929113234.1726-1-vulab@iscas.ac.cn Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
1 parent 1cb053e commit 6cdc4d4

1 file changed

Lines changed: 2 additions & 0 deletions

File tree

drivers/power/supply/rt5033_charger.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -701,6 +701,8 @@ static int rt5033_charger_probe(struct platform_device *pdev)
701701
np_conn = of_parse_phandle(pdev->dev.of_node, "richtek,usb-connector", 0);
702702
np_edev = of_get_parent(np_conn);
703703
charger->edev = extcon_find_edev_by_node(np_edev);
704+
of_node_put(np_edev);
705+
of_node_put(np_conn);
704706
if (IS_ERR(charger->edev)) {
705707
dev_warn(charger->dev, "no extcon device found in device-tree\n");
706708
goto out;

0 commit comments

Comments
 (0)