phy: apple: atc: Add missing mutex_unlock in error case

jannau · jannau · commit 6d06054c1a72 · 2025-03-28T21:37:13.000+01:00
Reported-by: kernel test robot <lkp@intel.com> Reported-by: Julia Lawall <julia.lawall@inria.fr> Closes: https://lore.kernel.org/r/202410021851.sGmBSrDd-lkp@intel.com/ Signed-off-by: Janne Grunau <j@jannau.net>
diff --git a/drivers/phy/apple/atc.c b/drivers/phy/apple/atc.c
@@ -1624,6 +1624,7 @@ static int atcphy_usb3_power_on(struct phy *phy)
 
 	if (atcphy->mode != atcphy->target_mode) {
 		dev_err(atcphy->dev, "ATCPHY did not come up; won't allow dwc3 to come up.\n");
+		mutex_unlock(&atcphy->lock);
 		return -EINVAL;
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -1624,6 +1624,7 @@ static int atcphy_usb3_power_on(struct phy *phy)`
`1624`	`1624`
`1625`	`1625`	`if (atcphy->mode != atcphy->target_mode) {`
`1626`	`1626`	`dev_err(atcphy->dev, "ATCPHY did not come up; won't allow dwc3 to come up.\n");`
	`1627`	`+ mutex_unlock(&atcphy->lock);`
`1627`	`1628`	`return -EINVAL;`
`1628`	`1629`	`}`
`1629`	`1630`