Skip to content

Commit 6d60354

Browse files
YuxuanZuoNicolas Schier
authored andcommitted
kbuild: Fix permissions of modules.builtin.modinfo
Currently, modules.builtin.modinfo is created with executable permissions (0755). This is because after commit 39cfd5b ("kbuild: extract modules.builtin.modinfo from vmlinux.unstripped"), modules.builtin.modinfo is extracted from vmlinux.unstripped using objcopy. When extracting sections, objcopy inherits attributes from the source ELF file. Since modules.builtin.modinfo is a data file and not an executable, it should have regular file permissions (0644). The executable bit can trigger warnings in Debian's Lintian tool. Explicitly remove the executable bit after generation. Fixes: 39cfd5b ("kbuild: extract modules.builtin.modinfo from vmlinux.unstripped") Signed-off-by: Ethan Zuo <yuxuan.zuo@outlook.com> Link: https://patch.msgid.link/SY0P300MB0609F6916B24ADF65502940B9C91A@SY0P300MB0609.AUSP300.PROD.OUTLOOK.COM Signed-off-by: Nicolas Schier <nsc@kernel.org>
1 parent 62089b8 commit 6d60354

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

scripts/Makefile.vmlinux

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,8 @@ vmlinux: vmlinux.unstripped FORCE
113113
# what kmod expects to parse.
114114
quiet_cmd_modules_builtin_modinfo = GEN $@
115115
cmd_modules_builtin_modinfo = $(cmd_objcopy); \
116-
sed -i 's/\x00\+$$/\x00/g' $@
116+
sed -i 's/\x00\+$$/\x00/g' $@; \
117+
chmod -x $@
117118

118119
OBJCOPYFLAGS_modules.builtin.modinfo := -j .modinfo -O binary
119120

0 commit comments

Comments
 (0)