Skip to content

Commit 6f539f3

Browse files
Uwe Kleine-Königsre
authored andcommitted
power: reset: atc260x-poweroff: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Link: https://lore.kernel.org/r/20231104211501.3676352-22-u.kleine-koenig@pengutronix.de Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
1 parent a31438e commit 6f539f3

1 file changed

Lines changed: 2 additions & 4 deletions

File tree

drivers/power/reset/atc260x-poweroff.c

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -233,7 +233,7 @@ static int atc260x_pwrc_probe(struct platform_device *pdev)
233233
return ret;
234234
}
235235

236-
static int atc260x_pwrc_remove(struct platform_device *pdev)
236+
static void atc260x_pwrc_remove(struct platform_device *pdev)
237237
{
238238
struct atc260x_pwrc *priv = platform_get_drvdata(pdev);
239239

@@ -243,13 +243,11 @@ static int atc260x_pwrc_remove(struct platform_device *pdev)
243243
}
244244

245245
unregister_restart_handler(&priv->restart_nb);
246-
247-
return 0;
248246
}
249247

250248
static struct platform_driver atc260x_pwrc_driver = {
251249
.probe = atc260x_pwrc_probe,
252-
.remove = atc260x_pwrc_remove,
250+
.remove_new = atc260x_pwrc_remove,
253251
.driver = {
254252
.name = "atc260x-pwrc",
255253
},

0 commit comments

Comments
 (0)