accel/amdxdna: Clear mailbox interrupt register during channel creation

houlz0507 · houlz0507 · commit 6ff9385c07aa · 2025-11-13T08:36:08.000-08:00
The mailbox interrupt register is not always cleared when a mailbox channel is created. This can leave stale interrupt states from previous operations. Fix this by explicitly clearing the interrupt register in the mailbox channel creation function. Fixes: b87f920 ("accel/amdxdna: Support hardware mailbox") Reviewed-by: Maciej Falkowski <maciej.falkowski@linux.intel.com> Signed-off-by: Lizhi Hou <lizhi.hou@amd.com> Link: https://patch.msgid.link/20251107181115.1293158-1-lizhi.hou@amd.com
diff --git a/drivers/accel/amdxdna/amdxdna_mailbox.c b/drivers/accel/amdxdna/amdxdna_mailbox.c
@@ -516,6 +516,7 @@ xdna_mailbox_create_channel(struct mailbox *mb,
 	}
 
 	mb_chann->bad_state = false;
+	mailbox_reg_write(mb_chann, mb_chann->iohub_int_addr, 0);
 
 	MB_DBG(mb_chann, "Mailbox channel created (irq: %d)", mb_chann->msix_irq);
 	return mb_chann;

Original file line number	Diff line number	Diff line change
`@@ -516,6 +516,7 @@ xdna_mailbox_create_channel(struct mailbox *mb,`
`516`	`516`	`}`
`517`	`517`
`518`	`518`	`mb_chann->bad_state = false;`
	`519`	`+ mailbox_reg_write(mb_chann, mb_chann->iohub_int_addr, 0);`
`519`	`520`
`520`	`521`	`MB_DBG(mb_chann, "Mailbox channel created (irq: %d)", mb_chann->msix_irq);`
`521`	`522`	`return mb_chann;`