Skip to content

Commit 706136c

Browse files
prabhakarladkuba-moo
authored andcommitted
net: ravb: Ensure memory write completes before ringing TX doorbell
Add a final dma_wmb() barrier before triggering the transmit request (TCCR_TSRQ) to ensure all descriptor and buffer writes are visible to the DMA engine. According to the hardware manual, a read-back operation is required before writing to the doorbell register to guarantee completion of previous writes. Instead of performing a dummy read, a dma_wmb() is used to both enforce the same ordering semantics on the CPU side and also to ensure completion of writes. Fixes: c156633 ("Renesas Ethernet AVB driver proper") Cc: stable@vger.kernel.org Co-developed-by: Fabrizio Castro <fabrizio.castro.jz@renesas.com> Signed-off-by: Fabrizio Castro <fabrizio.castro.jz@renesas.com> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> Link: https://patch.msgid.link/20251017151830.171062-5-prabhakar.mahadev-lad.rj@bp.renesas.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent 5370c31 commit 706136c

1 file changed

Lines changed: 8 additions & 0 deletions

File tree

drivers/net/ethernet/renesas/ravb_main.c

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2232,6 +2232,14 @@ static netdev_tx_t ravb_start_xmit(struct sk_buff *skb, struct net_device *ndev)
22322232
dma_wmb();
22332233
desc->die_dt = DT_FSINGLE;
22342234
}
2235+
2236+
/* Before ringing the doorbell we need to make sure that the latest
2237+
* writes have been committed to memory, otherwise it could delay
2238+
* things until the doorbell is rang again.
2239+
* This is in replacement of the read operation mentioned in the HW
2240+
* manuals.
2241+
*/
2242+
dma_wmb();
22352243
ravb_modify(ndev, TCCR, TCCR_TSRQ0 << q, TCCR_TSRQ0 << q);
22362244

22372245
priv->cur_tx[q] += num_tx_desc;

0 commit comments

Comments
 (0)