Skip to content

Commit 71476f9

Browse files
committed
irqchip/alpine-msi: Convert to lock guards
Convert lock/unlock pairs to guards and tidy up the code. No functional change. Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Signed-off-by: Nam Cao <namcao@linutronix.de> Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Link: https://lore.kernel.org/all/7886b9595aaf8e102f79364784f68dec9c49b023.1750860131.git.namcao@linutronix.de
1 parent 6e44ac4 commit 71476f9

1 file changed

Lines changed: 4 additions & 14 deletions

File tree

drivers/irqchip/irq-alpine-msi.c

Lines changed: 4 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -60,31 +60,21 @@ static int alpine_msix_allocate_sgi(struct alpine_msix_data *priv, int num_req)
6060
{
6161
int first;
6262

63-
spin_lock(&priv->msi_map_lock);
64-
65-
first = bitmap_find_next_zero_area(priv->msi_map, priv->num_spis, 0,
66-
num_req, 0);
67-
if (first >= priv->num_spis) {
68-
spin_unlock(&priv->msi_map_lock);
63+
guard(spinlock)(&priv->msi_map_lock);
64+
first = bitmap_find_next_zero_area(priv->msi_map, priv->num_spis, 0, num_req, 0);
65+
if (first >= priv->num_spis)
6966
return -ENOSPC;
70-
}
7167

7268
bitmap_set(priv->msi_map, first, num_req);
73-
74-
spin_unlock(&priv->msi_map_lock);
75-
7669
return priv->spi_first + first;
7770
}
7871

7972
static void alpine_msix_free_sgi(struct alpine_msix_data *priv, unsigned int sgi, int num_req)
8073
{
8174
int first = sgi - priv->spi_first;
8275

83-
spin_lock(&priv->msi_map_lock);
84-
76+
guard(spinlock)(&priv->msi_map_lock);
8577
bitmap_clear(priv->msi_map, first, num_req);
86-
87-
spin_unlock(&priv->msi_map_lock);
8878
}
8979

9080
static void alpine_msix_compose_msi_msg(struct irq_data *data, struct msi_msg *msg)

0 commit comments

Comments
 (0)