Skip to content

Commit 71bc2c6

Browse files
committed
NFSD: Rename a function parameter
Clean up: A function parameter called "rqstp" typically refers to an object of type "struct svc_rqst", so it's confusing when such an parameter refers to a different struct type with field names that are very similar to svc_rqst. Reviewed-by: Jeff Layton <jlayton@kernel.org> Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
1 parent 9c65001 commit 71bc2c6

1 file changed

Lines changed: 14 additions & 14 deletions

File tree

fs/nfsd/nfsctl.c

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1436,7 +1436,7 @@ unsigned int nfsd_net_id;
14361436

14371437
static int nfsd_genl_rpc_status_compose_msg(struct sk_buff *skb,
14381438
struct netlink_callback *cb,
1439-
struct nfsd_genl_rqstp *rqstp)
1439+
struct nfsd_genl_rqstp *genl_rqstp)
14401440
{
14411441
void *hdr;
14421442
u32 i;
@@ -1446,22 +1446,22 @@ static int nfsd_genl_rpc_status_compose_msg(struct sk_buff *skb,
14461446
if (!hdr)
14471447
return -ENOBUFS;
14481448

1449-
if (nla_put_be32(skb, NFSD_A_RPC_STATUS_XID, rqstp->rq_xid) ||
1450-
nla_put_u32(skb, NFSD_A_RPC_STATUS_FLAGS, rqstp->rq_flags) ||
1451-
nla_put_u32(skb, NFSD_A_RPC_STATUS_PROG, rqstp->rq_prog) ||
1452-
nla_put_u32(skb, NFSD_A_RPC_STATUS_PROC, rqstp->rq_proc) ||
1453-
nla_put_u8(skb, NFSD_A_RPC_STATUS_VERSION, rqstp->rq_vers) ||
1449+
if (nla_put_be32(skb, NFSD_A_RPC_STATUS_XID, genl_rqstp->rq_xid) ||
1450+
nla_put_u32(skb, NFSD_A_RPC_STATUS_FLAGS, genl_rqstp->rq_flags) ||
1451+
nla_put_u32(skb, NFSD_A_RPC_STATUS_PROG, genl_rqstp->rq_prog) ||
1452+
nla_put_u32(skb, NFSD_A_RPC_STATUS_PROC, genl_rqstp->rq_proc) ||
1453+
nla_put_u8(skb, NFSD_A_RPC_STATUS_VERSION, genl_rqstp->rq_vers) ||
14541454
nla_put_s64(skb, NFSD_A_RPC_STATUS_SERVICE_TIME,
1455-
ktime_to_us(rqstp->rq_stime),
1455+
ktime_to_us(genl_rqstp->rq_stime),
14561456
NFSD_A_RPC_STATUS_PAD))
14571457
return -ENOBUFS;
14581458

1459-
switch (rqstp->rq_saddr.sa_family) {
1459+
switch (genl_rqstp->rq_saddr.sa_family) {
14601460
case AF_INET: {
14611461
const struct sockaddr_in *s_in, *d_in;
14621462

1463-
s_in = (const struct sockaddr_in *)&rqstp->rq_saddr;
1464-
d_in = (const struct sockaddr_in *)&rqstp->rq_daddr;
1463+
s_in = (const struct sockaddr_in *)&genl_rqstp->rq_saddr;
1464+
d_in = (const struct sockaddr_in *)&genl_rqstp->rq_daddr;
14651465
if (nla_put_in_addr(skb, NFSD_A_RPC_STATUS_SADDR4,
14661466
s_in->sin_addr.s_addr) ||
14671467
nla_put_in_addr(skb, NFSD_A_RPC_STATUS_DADDR4,
@@ -1476,8 +1476,8 @@ static int nfsd_genl_rpc_status_compose_msg(struct sk_buff *skb,
14761476
case AF_INET6: {
14771477
const struct sockaddr_in6 *s_in, *d_in;
14781478

1479-
s_in = (const struct sockaddr_in6 *)&rqstp->rq_saddr;
1480-
d_in = (const struct sockaddr_in6 *)&rqstp->rq_daddr;
1479+
s_in = (const struct sockaddr_in6 *)&genl_rqstp->rq_saddr;
1480+
d_in = (const struct sockaddr_in6 *)&genl_rqstp->rq_daddr;
14811481
if (nla_put_in6_addr(skb, NFSD_A_RPC_STATUS_SADDR6,
14821482
&s_in->sin6_addr) ||
14831483
nla_put_in6_addr(skb, NFSD_A_RPC_STATUS_DADDR6,
@@ -1491,9 +1491,9 @@ static int nfsd_genl_rpc_status_compose_msg(struct sk_buff *skb,
14911491
}
14921492
}
14931493

1494-
for (i = 0; i < rqstp->rq_opcnt; i++)
1494+
for (i = 0; i < genl_rqstp->rq_opcnt; i++)
14951495
if (nla_put_u32(skb, NFSD_A_RPC_STATUS_COMPOUND_OPS,
1496-
rqstp->rq_opnum[i]))
1496+
genl_rqstp->rq_opnum[i]))
14971497
return -ENOBUFS;
14981498

14991499
genlmsg_end(skb, hdr);

0 commit comments

Comments
 (0)