Skip to content

Commit 7585800

Browse files
captain5050acmel
authored andcommitted
perf maps: Add find next entry to give entry after the given map
Use to remove map_rb_node use from machine.c. Signed-off-by: Ian Rogers <irogers@google.com> Cc: Adrian Hunter <adrian.hunter@intel.com> Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com> Cc: Andi Kleen <ak@linux.intel.com> Cc: Athira Rajeev <atrajeev@linux.vnet.ibm.com> Cc: Changbin Du <changbin.du@huawei.com> Cc: Colin Ian King <colin.i.king@gmail.com> Cc: Dmitrii Dolgov <9erthalion6@gmail.com> Cc: German Gomez <german.gomez@arm.com> Cc: Guilherme Amadio <amadio@gentoo.org> Cc: Huacai Chen <chenhuacai@kernel.org> Cc: Ingo Molnar <mingo@redhat.com> Cc: James Clark <james.clark@arm.com> Cc: Jiri Olsa <jolsa@kernel.org> Cc: K Prateek Nayak <kprateek.nayak@amd.com> Cc: Kajol Jain <kjain@linux.ibm.com> Cc: Kan Liang <kan.liang@linux.intel.com> Cc: Leo Yan <leo.yan@linaro.org> Cc: Li Dong <lidong@vivo.com> Cc: Liam Howlett <liam.howlett@oracle.com> Cc: Mark Rutland <mark.rutland@arm.com> Cc: Masami Hiramatsu <mhiramat@kernel.org> Cc: Miguel Ojeda <ojeda@kernel.org> Cc: Ming Wang <wangming01@loongson.cn> Cc: Namhyung Kim <namhyung@kernel.org> Cc: Nick Terrell <terrelln@fb.com> Cc: Paolo Bonzini <pbonzini@redhat.com> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Ravi Bangoria <ravi.bangoria@amd.com> Cc: Sandipan Das <sandipan.das@amd.com> Cc: Sean Christopherson <seanjc@google.com> Cc: Steinar H. Gunderson <sesse@google.com> Cc: Vincent Whitchurch <vincent.whitchurch@axis.com> Cc: Wenyu Liu <liuwenyu7@huawei.com> Cc: Yang Jihong <yangjihong1@huawei.com> Link: https://lore.kernel.org/r/20231207011722.1220634-21-irogers@google.com Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
1 parent e77b023 commit 7585800

3 files changed

Lines changed: 16 additions & 4 deletions

File tree

tools/perf/util/machine.c

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1762,12 +1762,11 @@ int machine__create_kernel_maps(struct machine *machine)
17621762

17631763
if (end == ~0ULL) {
17641764
/* update end address of the kernel map using adjacent module address */
1765-
struct map_rb_node *rb_node = maps__find_node(machine__kernel_maps(machine),
1766-
machine__kernel_map(machine));
1767-
struct map_rb_node *next = map_rb_node__next(rb_node);
1765+
struct map *next = maps__find_next_entry(machine__kernel_maps(machine),
1766+
machine__kernel_map(machine));
17681767

17691768
if (next)
1770-
machine__set_kernel_mmap(machine, start, map__start(next->map));
1769+
machine__set_kernel_mmap(machine, start, map__start(next));
17711770
}
17721771

17731772
out_put:

tools/perf/util/maps.c

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -663,6 +663,17 @@ struct map *maps__find_by_name(struct maps *maps, const char *name)
663663
return map;
664664
}
665665

666+
struct map *maps__find_next_entry(struct maps *maps, struct map *map)
667+
{
668+
struct map_rb_node *rb_node = maps__find_node(maps, map);
669+
struct map_rb_node *next = map_rb_node__next(rb_node);
670+
671+
if (next)
672+
return next->map;
673+
674+
return NULL;
675+
}
676+
666677
void maps__fixup_end(struct maps *maps)
667678
{
668679
struct map_rb_node *prev = NULL, *curr;

tools/perf/util/maps.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -136,6 +136,8 @@ int maps__fixup_overlap_and_insert(struct maps *maps, struct map *new);
136136

137137
struct map *maps__find_by_name(struct maps *maps, const char *name);
138138

139+
struct map *maps__find_next_entry(struct maps *maps, struct map *map);
140+
139141
int maps__merge_in(struct maps *kmaps, struct map *new_map);
140142

141143
void __maps__sort_by_name(struct maps *maps);

0 commit comments

Comments
 (0)