Skip to content

Commit 7608496

Browse files
shimodaybjorn-helgaas
authored andcommitted
misc: pci_endpoint_test: Document policy about adding pci_device_id
Add a comment suggesting that if the endpoint controller Vendor and Device ID are programmable, an existing entry might be usable for testing without having to add an entry to pci_endpoint_test_tbl[]. Link: https://lore.kernel.org/linux-pci/20240611125057.1232873-6-yoshihiro.shimoda.uh@renesas.com Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> Signed-off-by: Krzysztof Wilczyński <kwilczynski@kernel.org> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> Reviewed-by: Frank Li <Frank.Li@nxp.com>
1 parent a50c7de commit 7608496

1 file changed

Lines changed: 4 additions & 0 deletions

File tree

drivers/misc/pci_endpoint_test.c

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1014,6 +1014,10 @@ static const struct pci_endpoint_test_data rk3588_data = {
10141014
.irq_type = IRQ_TYPE_MSI,
10151015
};
10161016

1017+
/*
1018+
* If the controller's Vendor/Device ID are programmable, you may be able to
1019+
* use one of the existing entries for testing instead of adding a new one.
1020+
*/
10171021
static const struct pci_device_id pci_endpoint_test_tbl[] = {
10181022
{ PCI_DEVICE(PCI_VENDOR_ID_TI, PCI_DEVICE_ID_TI_DRA74x),
10191023
.driver_data = (kernel_ulong_t)&default_data,

0 commit comments

Comments
 (0)